Disallow GET_LOCK() calls in vttablet. #3900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweitzman
force-pushed
the
disallow_get_lock
branch
from
49789b0
to
d53fe80
Compare
|
@danieltahara was asking for a resurrection of this feature. Let me figure out his use case, etc. before moving forward on this. |
|
Looks like @danieltahara found a different way. I can merge this if you resolve the conflict. |
Named locks are unsafe with server-side connection pooling. See vitessio#3631 for background. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
dweitzman
force-pushed
the
disallow_get_lock
branch
from
d53fe80
to
771863d
Compare
|
Rebased |
sougou
approved these changes
Jun 2, 2018
notfelineit
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 12, 2024
…rNotifier to use a copy of the tables to prevent data races (vitessio#3900) * backport of 3891 * feat: fix build issues Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
andyedison
pushed a commit
to github/vitess-gh
that referenced
this pull request
Jul 29, 2024
…rNotifier to use a copy of the tables to prevent data races (vitessio#3900) * backport of 3891 * feat: fix build issues Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Named locks are unsafe with server-side connection pool.
See #3631 for background.
Signed-off-by: David Weitzman dweitzman@pinterest.com