Fixes for Docker bootstrap images #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise they may not re-download the latest versions of packages we fetch from the web.
|
LGTM |
enisoc
added a commit
that referenced
this pull request
May 5, 2015
Fixes for Docker bootstrap images
yields
added a commit
to planetscale/vitess
that referenced
this pull request
Aug 14, 2023
It seems like this was added back in 2015 when vitess used to use raw go get commands to build the image, the reasoning behind it was to ensure that the image has the most recent dependencies. This is no longer needed because in the image we correctly add go.* dep manifests and call go mod download. PR where this was added: vitessio#665 Signed-off-by: Amir Abushareb <yields@icloud.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also rebuilt and pushed the bootstrap images to pick up the latest grpc lib, which is needed after #662.