[Gen4] Implemented table alias functionality in the semantic analysis #7629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systay
force-pushed
the
gen4-table-aliases
branch
from
a68f4fa to
4239473
Compare
GuptaManan100
force-pushed
the
gen4-table-aliases
branch
from
4239473 to
fa60cbb
Compare
systay
force-pushed
the
gen4-table-aliases
branch
from
fa60cbb to
c61f7e2
Compare
systay
force-pushed
the
gen4-table-aliases
branch
from
c61f7e2 to
8b6e836
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
gen4-table-aliases
branch
from
619a11d to
18e61f0
Compare
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
gen4-table-aliases
branch
from
cfcb83a to
481e317
Compare
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui
approved these changes
Apr 15, 2021
Signed-off-by: Andres Taylor <andres@planetscale.com>
Comment on lines
+49
to
+52
| keyspace, err := vschema.DefaultKeyspace() | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
this will start failing for cases when there is no default database selected.
There was a problem hiding this comment.
hmmm... how come no tests are failing? do we need to add more tests to the planner?
you are probably absolutely correct about this comment. that being said - since this is not failing any tests, how about we take care of this in a separate PR? We should add more tests, and then also fix the issue
WDYT?
There was a problem hiding this comment.
I think we are introducing this check here, so it be be better to have a test that covers the error case if existing tests do not fail.
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
gen4-table-aliases
branch
from
b13224c to
18036f5
Compare
harshit-gangal
approved these changes
Apr 26, 2021
|
CI tests are failing. |
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
added
Component: Query Serving
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR teaches the semantic analysis how to deal with table aliases.
Every table mentioned in the
FROMwill now either be explicitly qualified with the database name, or the current database is used to qualify the table.This PR also adds support for routed tables, which depend on table aliases being available.
Checklist
NopeLots of tests addedNot requiredDeployment Notes
Impacted Areas in Vitess
Components that this PR will affect: