Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gen4: plan more opcodes #8254

Merged
merged 8 commits into from
Jun 3, 2021
Merged

gen4: plan more opcodes #8254

merged 8 commits into from
Jun 3, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented Jun 3, 2021 •
edited
Loading

Description

Makes it possible for gen4 to plan LIKE, IN, NOT IN, and IS NOT NULL plans better.

Related Issue(s)

#7280

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

systay added 2 commits June 3, 2021 09:49
@systay
gen4: better planning for NOT IN predicates
bda079e 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
refactoring of route_planning to make LIKE easier to add
d64a651 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay added Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Jun 3, 2021
systay added 2 commits June 3, 2021 11:24
@systay
add test for LIKE query
4c5ea9d 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
allow gen4 to plan LIKE using CFC vindexes
08e2a83 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay force-pushed the gen4-more-opcodes branch from 458fbf9 to 08e2a83 Compare June 3, 2021 09:25
@systay systay marked this pull request as ready for review June 3, 2021 09:25
@systay systay requested a review from harshit-gangal as a code owner June 3, 2021 09:25
@systay systay requested review from frouioui and GuptaManan100 June 3, 2021 09:25
systay added 2 commits June 3, 2021 12:03
@systay
renamed fields in IsExpr
c3b23ca 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
gen4: plan IS NULL
42a0a99 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay mentioned this pull request Jun 3, 2021
Closed
13 tasks
@systay
make parser🤦🏻
c823bc6 
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui
frouioui approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small nits. Looks awesome! Go Gen4 🚀

go/vt/vtgate/planbuilder/route_planning.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/route_planning.go Outdated Show resolved Hide resolved
@systay
refactor for readability as per review
2c6c50a 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal harshit-gangal merged commit 2988268 into vitessio:main Jun 3, 2021
@harshit-gangal harshit-gangal deleted the gen4-more-opcodes branch June 3, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@systay @harshit-gangal @frouioui