Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen4: outer joins #8312

Merged
merged 24 commits into from
Jun 23, 2021
Merged

gen4: outer joins #8312

merged 24 commits into from
Jun 23, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented Jun 11, 2021

Description

Teaches gen4 how to plan outer joins.

The big change is that we had to introduce a new abstraction - the operator tree.
Before this PR, gen4 turned queries into query graphs for planning. That is not enough to handle outer joins well, so we introduced the operator tree, which can be or contain a querygraph to represent the query.

Related Issue(s)

#7280

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

frouioui and others added 5 commits June 10, 2021 12:27
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@systay systay added Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Jun 11, 2021
frouioui added 2 commits June 11, 2021 14:49
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…eryGraph

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@systay systay force-pushed the gen4-outer-join branch from 87f0724 to 545c5db Compare June 16, 2021 08:03
systay and others added 5 commits June 16, 2021 15:30
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay marked this pull request as ready for review June 18, 2021 13:20
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay force-pushed the gen4-outer-join branch from 915c51a to bfe5b7f Compare June 21, 2021 05:22
systay and others added 5 commits June 21, 2021 08:26
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
(NoDeps, removal of keyspace name)

Co-authored-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@frouioui frouioui mentioned this pull request Jun 22, 2021
13 tasks
go/vt/sqlparser/analyzer.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/abstract/operator.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/abstract/outerjoin.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/abstract/outerjoin.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/abstract/querygraph.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/abstract/querygraph.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/route_planning.go Outdated Show resolved Hide resolved
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay added 2 commits June 22, 2021 18:32
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay force-pushed the gen4-outer-join branch from 7c7ec7c to 3f0a02b Compare June 22, 2021 16:50
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay systay merged commit dcdd254 into vitessio:main Jun 23, 2021
@systay systay deleted the gen4-outer-join branch June 23, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants