Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen4: support for union in subquery #8948

Merged
merged 6 commits into from
Oct 15, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented Oct 7, 2021

Description

Adds support for UNION inside sub queries to the gen4 planner

Related Issue(s)

#7280

@harshit-gangal harshit-gangal added Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Oct 7, 2021
@systay systay force-pushed the gen4-union-subquery branch from f77cafe to 20fe37d Compare October 13, 2021 15:26
@systay systay force-pushed the gen4-union-subquery branch 2 times, most recently from 6b6a00c to fe97562 Compare October 15, 2021 08:07
@systay systay marked this pull request as ready for review October 15, 2021 08:07
frouioui
frouioui previously approved these changes Oct 15, 2021
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frouioui frouioui dismissed their stale review October 15, 2021 08:27

Failing Unit Tests

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update TestSubqueryRewrite unit tests

harshit-gangal and others added 5 commits October 15, 2021 14:19
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay systay merged commit 8579459 into vitessio:main Oct 15, 2021
@systay systay deleted the gen4-union-subquery branch October 15, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants