Gen4: subquery refactor #8974
Merged
Gen4: subquery refactor #8974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouioui
added
Type: Enhancement
frouioui
force-pushed
the
gen4-subquery-refactor
branch
from
a91c309 to
2a7114d
Compare
systay
force-pushed
the
gen4-subquery-refactor
branch
2 times, most recently
from
c96d2bc to
7a6f71d
Compare
frouioui
force-pushed
the
gen4-subquery-refactor
branch
2 times, most recently
from
7f1f398 to
4937db9
Compare
…ning and its understanding Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…None Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
We should be able to handle calculating dependencies even if the expression is a slice and not valid as a map key. Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
gen4-subquery-refactor
branch
from
395edb6 to
dc15f61
Compare
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…es done on SelStmt Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
requested review from
GuptaManan100 and
harshit-gangal
as code owners
systay
reviewed
Oct 12, 2021
| @@ -1720,3 +1720,33 @@ func (node *RenameTable) Format(buf *TrackedBuffer) { | |||
| prefix = ", " | |||
| } | |||
| } | |||
|
|
|||
| func (node *ExtractedSubquery) Format(buf *TrackedBuffer) { | |||
There was a problem hiding this comment.
missing comment, and we should not create the new expressions here, we should create them when we create this struct, I think
There was a problem hiding this comment.
as the new struct is also an SQLNode, we can keep the Format function here.
systay
reviewed
Oct 12, 2021
GuptaManan100
approved these changes
Oct 12, 2021
| Original Expr // original expression that was replaced by this ExtractedSubquery | ||
| ArgName string | ||
| HasValuesArg string | ||
| OpCode int // this should really be engine.PulloutOpCode, but we cannot depend on engine :( |
There was a problem hiding this comment.
Should we move the opcode here then? or some other common package?
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
approved these changes
Oct 12, 2021
| @@ -1720,3 +1720,33 @@ func (node *RenameTable) Format(buf *TrackedBuffer) { | |||
| prefix = ", " | |||
| } | |||
| } | |||
|
|
|||
| func (node *ExtractedSubquery) Format(buf *TrackedBuffer) { | |||
There was a problem hiding this comment.
as the new struct is also an SQLNode, we can keep the Format function here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request contains a big refactor of the subqueries system in Gen4. We have introduced a new AST struct
ExtractedSubquerythat replaces entire subquery expression and its parents if it is a comparison or an exists (i.e:(select 1),a = (select 1),exists (select 1),a in (select 1), etc). Now, instead of directly rewriting the subquery with its arguments (i.e::__sq1,:__sq_has_values1, etc), we rewrite it with anExtractedSubquery. If in the later planning phase we need to rewrite the subquery to its original form we can directly useExtractedSubquery'sOriginalfield, and if we wish to keep the subquery as an argument,ExtractedSubquery's format function will do it.Related Issue(s)
Checklist