Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gen4: Subquery dependencies update #8998

Merged
merged 5 commits into from
Oct 14, 2021
Merged

gen4: Subquery dependencies update #8998

merged 5 commits into from
Oct 14, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented Oct 14, 2021 •
edited
Loading

Description

The way our semantic analysis works was causing problems for the plan building. Two different problems are solved by this changeset:

  1. Rewriting away subqueries did not update the binding information, so even when a subquery was removed from the query, the binding information was not updated.
  2. Dependencies from inside the subquery were leaking out. A small example will help illustrate the problem:
select (select col from foo), baz from bar

The col on the inside of the subquery has a dependency on foo. This was leaking out so that the subquery expression also had a dependency to foo, when it really shouldn't.

Related Issue(s)

#7280

@systay systay added Component: Query Serving release notes Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Oct 14, 2021
@systay systay changed the title Subquery deps fix gen4: Subquery dependencies update Oct 14, 2021
GuptaManan100 and others added 4 commits October 14, 2021 11:42
@GuptaManan100 @systay
added failing testcases as unit tests
897cfa7 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 @systay
fixed subquery binding
3954083 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@systay
clean up code and add queries to test the new dependency code
4090a69 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
update test assertions
c0d1609 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay force-pushed the subquery-deps-fix branch from 2fb33b2 to c0d1609 Compare October 14, 2021 09:42
@systay systay marked this pull request as ready for review October 14, 2021 09:42
@systay
update query to test a more interesting situation
438a96d 
Signed-off-by: Andres Taylor <andres@planetscale.com>
GuptaManan100
GuptaManan100 approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! 🌀

@systay systay merged commit 180ccfb into vitessio:main Oct 14, 2021
@systay systay deleted the subquery-deps-fix branch October 14, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@systay @GuptaManan100