Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gen4 - Fix select expressions having dependencies from both sides of a join #9051

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Gen4 - Fix select expressions having dependencies from both sides of a join #9051

merged 2 commits into from
Oct 21, 2021

Conversation

GuptaManan100
Copy link
Member

Description

This PR adds support to Gen4 for supporting select expressions with multiple dependencies like in select user.id * user_id as amount from user, user_extra

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
fixed pushing expressions having dependencies from both sides of a join
d9ebf25 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 mentioned this pull request Oct 21, 2021
Merged
3 tasks
frouioui
frouioui approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

go/vt/vtgate/planbuilder/horizon_planning.go Outdated Show resolved Hide resolved
@GuptaManan100
minor function definition refactor
7fa24a0 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 merged commit 20f8268 into vitessio:main Oct 21, 2021
@GuptaManan100 GuptaManan100 deleted the join-dependency-fix branch October 21, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay systay approved these changes

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gen4 does not support select expressions having multiple dependencies
4 participants
@GuptaManan100 @systay @harshit-gangal @frouioui