Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail unsupported queries properly in semi-join #9098

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

GuptaManan100
Copy link
Member

Description

After the introduction of semi-join in Gen4, there were queries which produced incorrect results and failed on execution time.

One such query was -

select 1 from user u where u.col = 6 or exists (select 1 from user_extra ue where ue.col = u.col and u.col = ue.col2)

This PR handles that issue and fails properly on the planner level instead of producing incorrect plans.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 merged commit 6f8c61b into vitessio:main Oct 27, 2021
@GuptaManan100 GuptaManan100 deleted the semi-join-fail branch October 27, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants