Update the vstream doc in v17.0 #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: yoheimuta <yoheimuta@gmail.com>
yoheimuta
force-pushed
the
vstream_docs_vcopy
branch
from
785e758 to
0b066d5
Compare
mattlord
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
This is great! Thank you @yoheimuta ! ❤️ I only had some very minor suggestions. Let me know what you think. I can then get this merged.
| @@ -197,6 +200,51 @@ for { | |||
| ... | |||
| ``` | |||
|
|
|||
| #### Copy all tables from all shards in the ks keyspace | |||
| } | ||
| filter := &binlogdatapb.Filter{ | ||
| Rules: []*binlogdatapb.Rule{{ | ||
| Match: "/.*/", |
There was a problem hiding this comment.
FWIW, I don't think it has to end with a forward slash does it?
There was a problem hiding this comment.
Yes, you're right. I have fixed it with commit 62a50f3.
Co-authored-by: Matt Lord <mattalord@gmail.com> Signed-off-by: yohei yoshimuta <yoheimuta@gmail.com>
Co-authored-by: Matt Lord <mattalord@gmail.com> Signed-off-by: yohei yoshimuta <yoheimuta@gmail.com>
Co-authored-by: Matt Lord <mattalord@gmail.com> Signed-off-by: yohei yoshimuta <yoheimuta@gmail.com>
Co-authored-by: Matt Lord <mattalord@gmail.com> Signed-off-by: yohei yoshimuta <yoheimuta@gmail.com>
Co-authored-by: Matt Lord <mattalord@gmail.com> Signed-off-by: yohei yoshimuta <yoheimuta@gmail.com>
Signed-off-by: yoheimuta <yoheimuta@gmail.com>
yoheimuta
force-pushed
the
vstream_docs_vcopy
branch
from
b4cd305 to
62a50f3
Compare
mattlord
reviewed
Mar 16, 2023
Comment on lines
203
to
204
| </br> | ||
| #### Copy All Tables From All Shards in the `ks` Keyspace |
There was a problem hiding this comment.
Looks like Netlify wants an empty line between these two. Sorry, I didn't realize that.
Signed-off-by: yoheimuta <yoheimuta@gmail.com>
|
@mattlord Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the doc to include the work: vitessio/vitess#11886
Quick link: https://deploy-preview-1410--vitess.netlify.app/docs/17.0/reference/vreplication/vstream