Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viper website docs #1482

Merged
merged 4 commits into from
Jun 30, 2023
Merged

viper website docs #1482

merged 4 commits into from
Jun 30, 2023

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented May 24, 2023

A large portion of this was extracted from parts of the doc written in vitessio/vitess#11456

I still need to update the markdown links to make them work here, but the text stands on its own

@ajm188 ajm188 added the do-not-merge PR contains issues or is dependent on another task label May 24, 2023
@ajm188 ajm188 requested a review from mattlord May 24, 2023 10:51
@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit fbcbac8
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/649f2ca4cba5530007765f0a
😎 Deploy Preview https://deploy-preview-1482--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ajm188 ajm188 removed the do-not-merge PR contains issues or is dependent on another task label May 24, 2023
@ajm188 ajm188 changed the title WIP viper website docs viper website docs May 25, 2023
Copy link
Collaborator

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions and requests. Beyond that, we need to rebase this on the prod branch and copy the new files to the 18.0 docs as well.

content/en/docs/17.0/reference/viper/basic.md Outdated Show resolved Hide resolved
content/en/docs/17.0/reference/viper/overview.md Outdated Show resolved Hide resolved
content/en/docs/17.0/reference/viper/dynamic_values.md Outdated Show resolved Hide resolved
Andrew Mason added 4 commits June 30, 2023 15:25
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Copy link
Collaborator

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Comment on lines +17 to +19
[viper]: https://github.com/spf13/viper
[hugo]: https://github.com/gohugoio/hugo
[kops]: https://github.com/kubernetes/kops
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I didn't even know you could do this. 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's part of the markdown spec! it's rad (for either super-long link targets or targets that you need to link to repeatedly)

@ajm188 ajm188 merged commit 4aa0db5 into prod Jun 30, 2023
@ajm188 ajm188 deleted the andrew/viper branch June 30, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants