-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recommendations and warnings to supported platforms page #949
Conversation
✔️ Deploy Preview for vitess ready! 🔨 Explore the source changes: 73f239e 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitess/deploys/61ef157e4650340008f30ee5 😎 Browse the preview: https://deploy-preview-949--vitess.netlify.app |
1637ef6
to
169b5ef
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
169b5ef
to
1687381
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good.
I think it's also worth modifying this statement so that it doesn't appear to contradict the next line (which says MySQL v8 is recommended)
With MySQL 5.6 reaching end of life in February 2021, it is recommended to deploy MySQL 5.7 and later.
to
With MySQL 5.6 reaching end of life in February 2021, it is recommended to upgrade to MySQL 5.7 or later.
WDYT?
Good catch! I think that entire line becomes redundant in the older docs since we now have a note about recommended version and the 5.6 EOL. I made this new commit: 2fd9df3 |
Where is that note? Sorry, all I'm seeing is that you deleted the line about 5.6 EOL. |
The full text is now:
We note the full version span (5.6-8.0), recommend 8.0, and warn about the 5.6 EOL. |
2fd9df3
to
bb5693a
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
bb5693a
to
73f239e
Compare
We should steer users in the direction we believe is best and caution them about ones that we know may be problematic.
This is related to: vitessio/vitess#9518
Links: