Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommendations and warnings to supported platforms page #949

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

mattlord
Copy link
Collaborator

@mattlord mattlord commented Jan 22, 2022

@netlify
Copy link

netlify bot commented Jan 22, 2022

✔️ Deploy Preview for vitess ready!

🔨 Explore the source changes: 73f239e

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitess/deploys/61ef157e4650340008f30ee5

😎 Browse the preview: https://deploy-preview-949--vitess.netlify.app

@mattlord mattlord force-pushed the mariadb_support_clarifications branch from 1637ef6 to 169b5ef Compare January 22, 2022 22:30
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the mariadb_support_clarifications branch from 169b5ef to 1687381 Compare January 22, 2022 22:37
Copy link
Member

@derekperkins derekperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.
I think it's also worth modifying this statement so that it doesn't appear to contradict the next line (which says MySQL v8 is recommended)

With MySQL 5.6 reaching end of life in February 2021, it is recommended to deploy MySQL 5.7 and later.

to

With MySQL 5.6 reaching end of life in February 2021, it is recommended to upgrade to MySQL 5.7 or later.

WDYT?

@mattlord
Copy link
Collaborator Author

This is good. I think it's also worth modifying this statement so that it doesn't appear to contradict the next line (which says MySQL v8 is recommended)

Good catch! I think that entire line becomes redundant in the older docs since we now have a note about recommended version and the 5.6 EOL. I made this new commit: 2fd9df3

@mattlord mattlord requested a review from deepthi January 24, 2022 18:56
@deepthi
Copy link
Member

deepthi commented Jan 24, 2022

I think that entire line becomes redundant in the older docs since we now have a note about recommended version and the 5.6 EOL.

Where is that note? Sorry, all I'm seeing is that you deleted the line about 5.6 EOL.

@mattlord
Copy link
Collaborator Author

mattlord commented Jan 24, 2022

I think that entire line becomes redundant in the older docs since we now have a note about recommended version and the 5.6 EOL.

Where is that note? Sorry, all I'm seeing is that you deleted the line about 5.6 EOL.

The full text is now:

Vitess supports the core features of MySQL versions 5.6 to 8.0, with [some limitations](../../reference/compatibility/mysql-compatibility/). Vitess also supports [Percona Server for MySQL](https://www.percona.com/software/mysql-database/percona-server) versions 5.6 to 8.0.

 {{< info >}}For new Vitess installations, MySQL or Percona Server for MySQL version 8 are recommended.{{< /info >}}

 {{< warning >}}
 MySQL and Percona Server for MySQL 5.6 are no longer supported in Vitess 13.0 and later.
 {{< /warning >}}

We note the full version span (5.6-8.0), recommend 8.0, and warn about the 5.6 EOL.

@mattlord mattlord force-pushed the mariadb_support_clarifications branch from 2fd9df3 to bb5693a Compare January 24, 2022 21:07
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the mariadb_support_clarifications branch from bb5693a to 73f239e Compare January 24, 2022 21:09
@deepthi deepthi merged commit 8106fdd into prod Jan 25, 2022
@deepthi deepthi deleted the mariadb_support_clarifications branch January 25, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants