fix(vitest): apply slowTestThreshold to all reporters (#4876)

vitest-dev · Jan 5, 2024 · 1769c79 · 1769c79
1 parent 7719e79
commit 1769c79
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/packages/vitest/src/node/reporters/benchmark/table/index.ts b/packages/vitest/src/node/reporters/benchmark/table/index.ts
@@ -22,6 +22,7 @@ export class TableReporter extends BaseReporter {
     if (this.isTTY) {
       this.rendererOptions.logger = this.ctx.logger
       this.rendererOptions.showHeap = this.ctx.config.logHeapUsage
+      this.rendererOptions.slowTestThreshold = this.ctx.config.slowTestThreshold
       const files = this.ctx.state.getFiles(this.watchFilters)
       if (!this.renderer)
         this.renderer = createTableRenderer(files, this.rendererOptions).start()

diff --git a/packages/vitest/src/node/reporters/benchmark/table/tableRender.ts b/packages/vitest/src/node/reporters/benchmark/table/tableRender.ts
@@ -11,10 +11,9 @@ export interface ListRendererOptions {
   renderSucceed?: boolean
   logger: Logger
   showHeap: boolean
+  slowTestThreshold: number
 }
 
-const DURATION_LONG = 300
-
 const outputMap = new WeakMap<Task, string>()
 
 function formatFilepath(path: string) {
@@ -121,7 +120,7 @@ export function renderTree(tasks: Task[], options: ListRendererOptions, level =
       suffix += ` ${c.dim(c.gray('[skipped]'))}`
 
     if (task.result?.duration != null) {
-      if (task.result.duration > DURATION_LONG)
+      if (task.result.duration > options.slowTestThreshold)
         suffix += c.yellow(` ${Math.round(task.result.duration)}${c.dim('ms')}`)
     }
 

diff --git a/packages/vitest/src/node/reporters/default.ts b/packages/vitest/src/node/reporters/default.ts
@@ -33,6 +33,7 @@ export class DefaultReporter extends BaseReporter {
     if (this.isTTY) {
       this.rendererOptions.logger = this.ctx.logger
       this.rendererOptions.showHeap = this.ctx.config.logHeapUsage
+      this.rendererOptions.slowTestThreshold = this.ctx.config.slowTestThreshold
       this.rendererOptions.mode = this.mode
       const files = this.ctx.state.getFiles(this.watchFilters)
       if (!this.renderer)

diff --git a/packages/vitest/src/node/reporters/renderers/listRenderer.ts b/packages/vitest/src/node/reporters/renderers/listRenderer.ts
@@ -11,11 +11,10 @@ export interface ListRendererOptions {
   renderSucceed?: boolean
   logger: Logger
   showHeap: boolean
+  slowTestThreshold: number
   mode: VitestRunMode
 }
 
-const DURATION_LONG = 300
-
 const outputMap = new WeakMap<Task, string>()
 
 function formatFilepath(path: string) {
@@ -115,7 +114,7 @@ export function renderTree(tasks: Task[], options: ListRendererOptions, level =
       suffix += c.yellow(` (repeat x${task.result.repeatCount})`)
 
     if (task.result?.duration != null) {
-      if (task.result.duration > DURATION_LONG)
+      if (task.result.duration > options.slowTestThreshold)
         suffix += c.yellow(` ${Math.round(task.result.duration)}${c.dim('ms')}`)
     }