Skip to content

Commit

Permalink
fix(forks): wrap defines to support undefined values
Browse files Browse the repository at this point in the history
  • Loading branch information
AriPerkkio committed Feb 26, 2024
1 parent d55b089 commit 9242911
Show file tree
Hide file tree
Showing 5 changed files with 43 additions and 0 deletions.
11 changes: 11 additions & 0 deletions packages/vitest/src/runtime/workers/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,16 @@ export function unwrapSerializableConfig(config: ResolvedConfig) {
config.testNamePattern = parseRegexp(testNamePattern.slice(REGEXP_WRAP_PREFIX.length))
}

if (config.defines && Array.isArray(config.defines.keys) && config.defines.original) {
const { keys, original } = config.defines
const defines: ResolvedConfig['defines'] = {}

// Apply all keys from the original. Entries which had undefined value are missing from original now
for (const key of keys)
defines[key] = original[key]

config.defines = defines
}

return config
}
6 changes: 6 additions & 0 deletions packages/vitest/src/utils/config-helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,19 @@ export function getOutputFile(config: PotentialConfig | undefined, reporter: Bui
*/
export function wrapSerializableConfig(config: ResolvedConfig) {
let testNamePattern = config.testNamePattern
let defines = config.defines

// v8 serialize does not support regex
if (testNamePattern && typeof testNamePattern !== 'string')
testNamePattern = `${REGEXP_WRAP_PREFIX}${testNamePattern.toString()}` as unknown as RegExp

// v8 serialize drops properties with undefined value
if (defines)
defines = { keys: Object.keys(defines), original: defines }

return {
...config,
testNamePattern,
defines,
} as ResolvedConfig
}
11 changes: 11 additions & 0 deletions test/core/test/define-ssr.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ import { afterAll, expect, test } from 'vitest'
declare let __DEFINE__: string
declare let __JSON__: any
declare let __MODE__: string
declare let __UNDEFINED__: undefined
declare let __NULL__: null
declare let __ZERO__: 0
declare let __FALSE__: false
declare let SOME: {
VARIABLE: string
SOME: {
Expand Down Expand Up @@ -64,3 +68,10 @@ test('dotted defines are processed by Vite, but cannot be reassigned', () => {
SOME.VARIABLE = 'new variable'
expect(SOME.VARIABLE).not.toBe('new variable')
})

test('falsy defines are passed', () => {
expect(__UNDEFINED__).toBe(undefined)
expect(__NULL__).toBe(null)
expect(__ZERO__).toBe(0)
expect(__FALSE__).toBe(false)
})
11 changes: 11 additions & 0 deletions test/core/test/define-web.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ import { afterAll, expect, test } from 'vitest'
declare let __DEFINE__: string
declare let __JSON__: any
declare let __MODE__: string
declare let __UNDEFINED__: undefined
declare let __NULL__: null
declare let __ZERO__: 0
declare let __FALSE__: false
declare let SOME: {
VARIABLE: string
SOME: {
Expand Down Expand Up @@ -61,3 +65,10 @@ test('dotted defines can be reassigned', () => {
SOME.VARIABLE = 'new variable'
expect(SOME.VARIABLE).toBe('new variable')
})

test('falsy defines are passed', () => {
expect(__UNDEFINED__).toBe(undefined)
expect(__NULL__).toBe(null)
expect(__ZERO__).toBe(0)
expect(__FALSE__).toBe(false)
})
4 changes: 4 additions & 0 deletions test/core/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ export default defineConfig({
'__MODE__': 'process.env.MODE',
'SOME.VARIABLE': '"variable"',
'SOME.SOME.VARIABLE': '"nested variable"',
'__UNDEFINED__': undefined,
'__NULL__': null,
'__ZERO__': 0,
'__FALSE__': false,
},
resolve: {
alias: [
Expand Down

0 comments on commit 9242911

Please sign in to comment.