chore(deps): update vite #5311

hi-ogawa · 2024-02-29T10:36:07Z

Description

Related #5123 (comment), #5193

I tweaked vite-node watch test cases with a quick workaround. I'll see how others go on CI.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

netlify · 2024-02-29T10:38:18Z

✅ Deploy Preview for fastidious-cascaron-4ded94 ready!

Name	Link
🔨 Latest commit	`d2ac106`
🔍 Latest deploy log	https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6610a6a7e737fd0008786370
😎 Deploy Preview	https://deploy-preview-5311--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hi-ogawa · 2024-03-01T05:31:32Z

Maybe flakiness increased or maybe it's just same as before. I retried three times and Windows CI hasn't go through yet.
https://github.com/vitest-dev/vitest/actions/runs/8106298865?pr=5311

sheremet-va · 2024-03-01T08:06:33Z

Maybe flakiness increased or maybe it's just same as before. I retried three times and Windows CI hasn't go through yet.

https://github.com/vitest-dev/vitest/actions/runs/8106298865?pr=5311

Yea, it increased. I have another PR open with this change and it's not merged because of the flakiness. We need to rewrite the waitForWatcher to wait for a specific file. The watcher emits ready event too soon.

hi-ogawa · 2024-03-01T08:35:33Z

The watcher emits ready event too soon.

@sheremet-va Do you know where this change is coming from? I couldn't find any specific change on Vite, so maybe something from chokidar (bumped to 3.6.0 in vitejs/vite#15803)?

sheremet-va · 2024-03-03T17:52:57Z

The watcher emits ready event too soon.

@sheremet-va Do you know where this change is coming from? I couldn't find any specific change on Vite, so maybe something from chokidar (bumped to 3.6.0 in vitejs/vite#15803)?

Could be anything, I don't know why this started happening, but watcher was always unstable.

sheremet-va · 2024-03-03T17:54:32Z

Maybe we can pass down a ENV variable and wait for it to appear in watcher.getWatched()? Like here: https://github.com/vitejs/vite/blob/63a39c244b08cf1f2299bc2c3cfddcb82070d05b/playground/hmr-ssr/__tests__/hmr.spec.ts#L971

hi-ogawa · 2024-03-04T06:15:31Z

Thanks for the pointer. I didn't know you were referring watcher.getWatched() when you were talking about vite runtime tests #5123 (comment).

For vite-node tests, we can wait for entry files to be included watcher.getWatched(), but I'm not sure what we should target for Vitest watch tests.

sheremet-va · 2024-03-04T19:39:53Z

For vite-node tests, we can wait for entry files to be included watcher.getWatched(), but I'm not sure what we should target for Vitest watch tests.

We can use something like this VITEST_TEST_WATCHER_FILE=filename vitest run

This reverts commit d0f92c5.

hi-ogawa · 2024-03-06T00:54:46Z

We can use something like this VITEST_TEST_WATCHER_FILE=filename vitest run

Failing CI is indicating that runVitestCli is stuck before outputting Waiting for file changes:

https://github.com/vitest-dev/vitest/actions/runs/8135325279/job/22229683329#step:10:977

vitest/test/test-utils/index.ts

Lines 191 to 196 in c3eb8de

    
           if (args.includes('--watch')) { 
        
             if (command === 'vitest') // Wait for initial test run to complete 
        
               await cli.waitForStdout('Waiting for file changes') 
        
             // make sure watcher is ready 
        
             await cli.waitForStdout('[debug] watcher is ready') 
        
             cli.stdout = cli.stdout.replace('[debug] watcher is ready\n', '')

So, I'm not sure if this flakiness can be fixed by waiting any specific file by VITEST_TEST_WATCHER_FILE=filename.

It maybe simply some performance degradation which makes Windows vmThreads harder to pass?

sheremet-va · 2024-03-26T09:53:31Z

packages/vite-node/src/cli.ts

@@ -131,6 +131,31 @@ async function run(files: string[], options: CliOptions = {}) {
    process.on('uncaughtException', (err) => {
      console.error(c.red('[vite-node] Failed to execute file: \n'), err)
    })
+
+    if (process.env.VITE_TEST_WATCHER_DEBUG) {


Can we add process.env.VITE_TEST_WATCHER_DEBUG: false in rollup config (under a condition like "production" build) so this is removed when bundling?

It looks like I can use process.env.ROLLUP_WATCH to remove this only on build 17aa695

Ah, this obviously breaks CI since it uses build... Let me think about a different way.

sheremet-va · 2024-03-26T09:54:11Z

Failing CI is indicating that runVitestCli is stuck before outputting Waiting for file changes:

This error happens more on Mac OS, to be honest. For some reason, this line is not reported at all.

hi-ogawa · 2024-03-28T07:51:25Z

Failing CI is indicating that runVitestCli is stuck before outputting Waiting for file changes:

This error happens more on Mac OS, to be honest. For some reason, this line is not reported at all.

While searching I noticed this one VITE_TEST_WATCHER_DEBUG, I noticed this darwin specific one:

vitest/packages/vite-node/src/hmr/emitter.ts

Lines 33 to 40 in dcc8dda

    
           // chokidar fsevents is unstable on macos when emitting "ready" event 
        
           if (process.platform === 'darwin' && process.env.VITE_TEST_WATCHER_DEBUG) { 
        
             return { 
        
               server: { 
        
                 watch: { 
        
                   useFsEvents: false, 
        
                   usePolling: false, 
        
                 },

Also on Vitest side:

vitest/packages/vitest/src/node/plugins/index.ts

Lines 124 to 128 in dcc8dda

    
           // chokidar fsevents is unstable on macos when emitting "ready" event 
        
           if (process.platform === 'darwin' && process.env.VITE_TEST_WATCHER_DEBUG) { 
        
             config.server!.watch!.useFsEvents = false 
        
             config.server!.watch!.usePolling = false 
        
           }

Maybe tweak this to see if it helps anything?

sheremet-va · 2024-04-05T15:31:21Z

@hi-ogawa do you think this is stable enough?

hi-ogawa · 2024-04-06T01:59:04Z

do you think this is stable enough?

Ubuntu and macos CI seems okay. I cannot really judge Windows behavior, so I can only hope it's stable enough.

hi-ogawa added 3 commits February 29, 2024 18:39

chore(desp): update vite 5.1.4

6dcc566

test: remove ssr.optimizeDeps hacks for pre Vite 5.1

4a30280

test(vite-node): robust watch test

bebc007

hi-ogawa added 2 commits March 1, 2024 12:48

chore: fix playwright ci

307df40

ci: fix playwright

cd8dfae

Merge branch 'main' into chore-vite-5.1.4

9444e11

hi-ogawa added 3 commits March 4, 2024 12:19

Merge branch 'main' into chore-vite-5.1.4

b0de10f

chore: tweak VITE_TEST_WATCHER_DEBUG

924cf0f

chore: cleanup

c41bca7

hi-ogawa added 4 commits March 5, 2024 11:16

ci: sequential test

d0f92c5

Merge branch 'main' into chore-vite-5.1.4

f087e64

Revert "ci: sequential test"

e33e558

This reverts commit d0f92c5.

Merge branch 'main' into chore-vite-5.1.4

b9a53d5

sheremet-va reviewed Mar 26, 2024

View reviewed changes

hi-ogawa added 2 commits March 28, 2024 16:32

Merge branch 'main' into chore-vite-5.1.4

ddecd5c

chore: 5.2.6

dcc8dda

hi-ogawa added 2 commits March 28, 2024 18:12

build: remove VITE_TEST_WATCHER_DEBUG on build

17aa695

ci: add NO_VITE_TEST_WATCHER_DEBUG for release build

355ffe3

hi-ogawa changed the title ~~chore(deps): update vite 5.1.4~~ chore(deps): update vite Apr 1, 2024

Merge branch 'main' into chore-vite-5.1.4

fce2087

This was referenced Apr 5, 2024

chore: update vite v5.2 #5421

Closed

chore(deps): update vite to 5.1.1 apply security patches #5193

Closed

Merge branch 'main' into chore-vite-5.1.4

d2ac106

hi-ogawa marked this pull request as ready for review April 6, 2024 01:59

sheremet-va approved these changes Apr 6, 2024

View reviewed changes

sheremet-va merged commit 75f48ba into vitest-dev:main Apr 6, 2024
18 of 19 checks passed

hi-ogawa deleted the chore-vite-5.1.4 branch April 6, 2024 07:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update vite #5311

chore(deps): update vite #5311

hi-ogawa commented Feb 29, 2024 •

edited

Loading

netlify bot commented Feb 29, 2024 •

edited

Loading

hi-ogawa commented Mar 1, 2024

sheremet-va commented Mar 1, 2024 •

edited

Loading

hi-ogawa commented Mar 1, 2024

sheremet-va commented Mar 3, 2024

sheremet-va commented Mar 3, 2024

hi-ogawa commented Mar 4, 2024

sheremet-va commented Mar 4, 2024 •

edited

Loading

hi-ogawa commented Mar 6, 2024 •

edited

Loading

sheremet-va Mar 26, 2024

hi-ogawa Mar 28, 2024

hi-ogawa Mar 28, 2024

sheremet-va commented Mar 26, 2024

hi-ogawa commented Mar 28, 2024 •

edited

Loading

sheremet-va commented Apr 5, 2024

hi-ogawa commented Apr 6, 2024

chore(deps): update vite #5311

chore(deps): update vite #5311

Conversation

hi-ogawa commented Feb 29, 2024 • edited Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

netlify bot commented Feb 29, 2024 • edited Loading

✅ Deploy Preview for fastidious-cascaron-4ded94 ready!

hi-ogawa commented Mar 1, 2024

sheremet-va commented Mar 1, 2024 • edited Loading

hi-ogawa commented Mar 1, 2024

sheremet-va commented Mar 3, 2024

sheremet-va commented Mar 3, 2024

hi-ogawa commented Mar 4, 2024

sheremet-va commented Mar 4, 2024 • edited Loading

hi-ogawa commented Mar 6, 2024 • edited Loading

sheremet-va Mar 26, 2024

Choose a reason for hiding this comment

hi-ogawa Mar 28, 2024

Choose a reason for hiding this comment

hi-ogawa Mar 28, 2024

Choose a reason for hiding this comment

sheremet-va commented Mar 26, 2024

hi-ogawa commented Mar 28, 2024 • edited Loading

sheremet-va commented Apr 5, 2024

hi-ogawa commented Apr 6, 2024

hi-ogawa commented Feb 29, 2024 •

edited

Loading

netlify bot commented Feb 29, 2024 •

edited

Loading

sheremet-va commented Mar 1, 2024 •

edited

Loading

sheremet-va commented Mar 4, 2024 •

edited

Loading

hi-ogawa commented Mar 6, 2024 •

edited

Loading

hi-ogawa commented Mar 28, 2024 •

edited

Loading