Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coverage): support --changed option #5314

Merged
merged 2 commits into from
Mar 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/guide/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ vitest --api=false

To run tests against changes made in the last commit, you can use `--changed HEAD~1`. You can also pass commit hash (e.g. `--changed 09a9920`) or branch name (e.g. `--changed origin/develop`).

When used with code coverage the report will contain only the files that were related to the changes.

If paired with the [`forceRerunTriggers`](/config/#forcereruntriggers) config option it will run the whole test suite if at least one of the files listed in the `forceRerunTriggers` list changes. By default, changes to the Vitest config file and `package.json` will always rerun the whole suite.

### shard
Expand Down
20 changes: 9 additions & 11 deletions packages/coverage-istanbul/src/provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -253,27 +253,25 @@ export class IstanbulCoverageProvider extends BaseCoverageProvider implements Co
}

async getCoverageMapForUncoveredFiles(coveredFiles: string[]) {
// Load, instrument and collect empty coverages from all files which
// are not already in the coverage map
const includedFiles = await this.testExclude.glob(this.ctx.config.root)
const allFiles = await this.testExclude.glob(this.ctx.config.root)
let includedFiles = allFiles.map(file => resolve(this.ctx.config.root, file))

if (this.ctx.config.changed)
includedFiles = (this.ctx.config.related || []).filter(file => includedFiles.includes(file))

const uncoveredFiles = includedFiles
.map(file => resolve(this.ctx.config.root, file))
.filter(file => !coveredFiles.includes(file))

const cacheKey = new Date().getTime()
const coverageMap = libCoverage.createCoverageMap({})

// Note that these cannot be run parallel as synchronous instrumenter.lastFileCoverage
// returns the coverage of the last transformed file
for (const [index, filename] of uncoveredFiles.entries()) {
debug('Uncovered file %s %d/%d', filename, index, uncoveredFiles.length)

// Make sure file is not served from cache
// so that instrumenter loads up requested file coverage
if (this.ctx.vitenode.fetchCache.has(filename))
this.ctx.vitenode.fetchCache.delete(filename)

await this.ctx.vitenode.transformRequest(filename)
Comment on lines -270 to -275
Copy link
Member Author

@AriPerkkio AriPerkkio Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this wasn't working as I expected it to. Files were served from Vite's cache when vite-node's fetchCache was cleared. This came up only with --changed flag as core.ts already loaded those files.

Minimal repro using vite-node:

import { createServer } from "vite";
import { ViteNodeServer } from "vite-node/server";

const server = await createServer({
  plugins: [
    {
      name: "logger",
      transform(code, id) {
        console.log(`[transform] ${id}`);
      },
    },
  ],
});
await server.pluginContainer.buildStart({});

const node = new ViteNodeServer(server);

// Should log [transform] ✅ 
console.log("transformRequest #1");
await node.transformRequest("./example.ts");


// Should log NOT [transform] ✅ 
console.log("transformRequest #2");
await node.transformRequest("./example.ts");

// Should log [transform] but it doesn't ❌ 
console.log("transformRequest #3");
node.fetchCache.clear();
node.fetchCaches.ssr.clear();
node.fetchCaches.web.clear();
await node.transformRequest("./example.ts");

node.server.close();


// Make sure file is not served from cache so that instrumenter loads up requested file coverage
await this.ctx.vitenode.transformRequest(`${filename}?v=${cacheKey}`)
const lastCoverage = this.instrumenter.lastFileCoverage()
coverageMap.addFileCoverage(lastCoverage)
}
Expand Down
9 changes: 7 additions & 2 deletions packages/coverage-v8/src/provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,14 @@ export class V8CoverageProvider extends BaseCoverageProvider implements Coverage
private async getUntestedFiles(testedFiles: string[]): Promise<RawCoverage> {
const transformResults = normalizeTransformResults(this.ctx.vitenode.fetchCache)

const includedFiles = await this.testExclude.glob(this.ctx.config.root)
const allFiles = await this.testExclude.glob(this.ctx.config.root)
let includedFiles = allFiles.map(file => resolve(this.ctx.config.root, file))

if (this.ctx.config.changed)
includedFiles = (this.ctx.config.related || []).filter(file => includedFiles.includes(file))

const uncoveredFiles = includedFiles
.map(file => pathToFileURL(resolve(this.ctx.config.root, file)))
.map(file => pathToFileURL(file))
.filter(file => !testedFiles.includes(file.pathname))

let merged: RawCoverage = { result: [] }
Expand Down
8 changes: 4 additions & 4 deletions packages/vitest/src/node/core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -382,10 +382,6 @@ export class Vitest {
}
}

// all subsequent runs will treat this as a fresh run
this.config.changed = false
this.config.related = undefined

if (files.length) {
// populate once, update cache on watch
await this.cache.stats.populateStats(this.config.root, files)
Expand Down Expand Up @@ -532,6 +528,10 @@ export class Vitest {

this.runningPromise = undefined
this.isFirstRun = false

// all subsequent runs will treat this as a fresh run
this.config.changed = false
this.config.related = undefined
})

return await this.runningPromise
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1134,6 +1134,89 @@ exports[`istanbul json report 1`] = `
},
},
},
"<process-cwd>/src/file-to-change.ts": {
"b": {},
"branchMap": {},
"f": {
"0": 0,
"1": 0,
},
"fnMap": {
"0": {
"decl": {
"end": {
"column": 22,
"line": 1,
},
"start": {
"column": 16,
"line": 1,
},
},
"loc": {
"end": {
"column": null,
"line": 3,
},
"start": {
"column": 22,
"line": 1,
},
},
"name": "run",
},
"1": {
"decl": {
"end": {
"column": 36,
"line": 5,
},
"start": {
"column": 16,
"line": 5,
},
},
"loc": {
"end": {
"column": null,
"line": 7,
},
"start": {
"column": 36,
"line": 5,
},
},
"name": "uncoveredFunction",
},
},
"path": "<process-cwd>/src/file-to-change.ts",
"s": {
"0": 0,
"1": 0,
},
"statementMap": {
"0": {
"end": {
"column": null,
"line": 2,
},
"start": {
"column": 2,
"line": 2,
},
},
"1": {
"end": {
"column": null,
"line": 6,
},
"start": {
"column": 2,
"line": 6,
},
},
},
},
"<process-cwd>/src/function-count.ts": {
"b": {},
"branchMap": {},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2777,6 +2777,153 @@ exports[`v8 json report 1`] = `
},
},
},
"<process-cwd>/src/file-to-change.ts": {
"all": true,
"b": {
"0": [
0,
],
},
"branchMap": {
"0": {
"line": 1,
"loc": {
"end": {
"column": 1,
"line": 7,
},
"start": {
"column": 0,
"line": 1,
},
},
"locations": [
{
"end": {
"column": 1,
"line": 7,
},
"start": {
"column": 0,
"line": 1,
},
},
],
"type": "branch",
},
},
"f": {
"0": 0,
},
"fnMap": {
"0": {
"decl": {
"end": {
"column": 1,
"line": 7,
},
"start": {
"column": 0,
"line": 1,
},
},
"line": 1,
"loc": {
"end": {
"column": 1,
"line": 7,
},
"start": {
"column": 0,
"line": 1,
},
},
"name": "(empty-report)",
},
},
"path": "<process-cwd>/src/file-to-change.ts",
"s": {
"0": 0,
"1": 0,
"2": 0,
"3": 0,
"4": 0,
"5": 0,
"6": 0,
},
"statementMap": {
"0": {
"end": {
"column": 23,
"line": 1,
},
"start": {
"column": 0,
"line": 1,
},
},
"1": {
"end": {
"column": 51,
"line": 2,
},
"start": {
"column": 0,
"line": 2,
},
},
"2": {
"end": {
"column": 1,
"line": 3,
},
"start": {
"column": 0,
"line": 3,
},
},
"3": {
"end": {
"column": 0,
"line": 4,
},
"start": {
"column": 0,
"line": 4,
},
},
"4": {
"end": {
"column": 37,
"line": 5,
},
"start": {
"column": 0,
"line": 5,
},
},
"5": {
"end": {
"column": 14,
"line": 6,
},
"start": {
"column": 0,
"line": 6,
},
},
"6": {
"end": {
"column": 1,
"line": 7,
},
"start": {
"column": 0,
"line": 7,
},
},
},
},
"<process-cwd>/src/function-count.ts": {
"all": false,
"b": {
Expand Down
22 changes: 22 additions & 0 deletions test/coverage-test/coverage-report-tests/changed.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { expect, test } from 'vitest'
import libCoverage from 'istanbul-lib-coverage'

import { readCoverageJson } from './utils'

test('report contains only the changed files', async () => {
const coverageJson = await readCoverageJson('./coverage/coverage-final.json')
const coverageMap = libCoverage.createCoverageMap(coverageJson as any)

expect(coverageMap.files()).toMatchInlineSnapshot(`
[
"<process-cwd>/src/file-to-change.ts",
"<process-cwd>/src/new-uncovered-file.ts",
]
`)

const uncoveredFile = coverageMap.fileCoverageFor('<process-cwd>/src/new-uncovered-file.ts').toSummary()
expect(uncoveredFile.lines.pct).toBe(0)

const changedFile = coverageMap.fileCoverageFor('<process-cwd>/src/file-to-change.ts').toSummary()
expect(changedFile.lines.pct).toBeGreaterThanOrEqual(50)
})
4 changes: 2 additions & 2 deletions test/coverage-test/coverage-report-tests/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ interface CoverageFinalJson {
* Read JSON coverage report from file system.
* Normalizes paths to keep contents consistent between OS's
*/
export async function readCoverageJson() {
const jsonReport = JSON.parse(readFileSync('./coverage/custom-json-report-name.json', 'utf8')) as CoverageFinalJson
export async function readCoverageJson(name = './coverage/custom-json-report-name.json') {
const jsonReport = JSON.parse(readFileSync(name, 'utf8')) as CoverageFinalJson

const normalizedReport: CoverageFinalJson['default'] = {}

Expand Down
6 changes: 6 additions & 0 deletions test/coverage-test/option-tests/changed.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { test } from 'vitest'
import { run } from '../src/file-to-change'

test('test case for changed file', () => {
run()
})
7 changes: 7 additions & 0 deletions test/coverage-test/src/file-to-change.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export function run() {
return 'This file will be modified by test cases'
}

export function uncoveredFunction() {
return 1 + 2
}
Loading
Loading