-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typecheck): run both runtime and typecheck tests if typecheck.include
overlaps with include
#6256
fix(typecheck): run both runtime and typecheck tests if typecheck.include
overlaps with include
#6256
Conversation
typecheck.include
overlaps with include
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
When this is done, will it still be true that test.each, for example, will not be able to be typechecked? If I have some tests that use test.each, will this mean no tests will be run if I enable typecheck? (this is what happens now, I get Unhandled Rejection: Error: test.each syntax is not supported when testing types) Awesome to see this looked at, I was just today looking for something exactly like this! |
Yes, it will still throw an error. Dynamic test names cannot be evaluated with a static typecheck. You can specify a glob pattern for tests that don't have |
typecheck.include
overlaps with include
typecheck.include
overlaps with include
5dd2471
to
dbac2c8
Compare
@AlexPaven typechecker doesn't throw an error now, but it prints a warning every time the compiler encounters an issue (I need to write more tests for that) with a code frame. This can be disabled with Typechecker tests are now displayed alongside the runtime tests, the test results are not merged together. This is incredibly hard to do because we need to reset the state every time the test reruns, but it's possible that typechecking will be finished faster than the test starts running. |
…echeck.include overlaps with include
0b7f139
to
6173593
Compare
Fixes #6151
Fixes #4766
Fixes #5019
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.