Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): move expect-type to dependencies #6705

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

mmkal
Copy link
Contributor

@mmkal mmkal commented Oct 14, 2024

Description

Previously, it was in devDependencies which meant it was bundled and shipped as part of vitest. It's better for it to live in dependencies:

  • non-breaking versions can be used by consumers if they want
  • customisable via package.json overrides, .pnpmfile.cjs etc.
  • security fixes can be applied

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed. chore(deps): bump expect-type to v1 #6349 (comment)
  • [ ] Ideally, include a test that fails without this PR but passes with it.
  • [ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Documentation

  • [ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Previously, it was in devDependencies which meant it was bundled and shipped as part of vitest. It's better for it to live in dependencies:

- non-breaking versions can be used by consumers if they want
- customisable via package.json overrides, .pnpmfile.cjs etc.
- security fixes can be applied
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 757d177
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/670d3809e9167600087039fa
😎 Deploy Preview https://deploy-preview-6705--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va merged commit e03725a into vitest-dev:main Oct 14, 2024
16 of 17 checks passed
@mmkal mmkal deleted the expect-type-2-deps branch October 14, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants