Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow a custom note when calling ctx.skip() dynamically #6805

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Oct 28, 2024

Description

Fixes #6212

TODO

  • Test TTY=true reporter
  • Test verbose TTY=false reporter

Maybe we should rethink the Vitest CLI output? 🤔 I feel like https://playwright.dev/docs/test-annotations#annotate-tests might be quite useful

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 9e58f74
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/671fbf8ca885100008813fcd
😎 Deploy Preview https://deploy-preview-6805--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va changed the title feat: allow a custom note when calling ctx.skip() dynamically feat: allow a custom note when calling ctx.skip() dynamically Oct 28, 2024
@sheremet-va sheremet-va marked this pull request as draft October 28, 2024 16:49
@sheremet-va sheremet-va marked this pull request as ready for review October 28, 2024 17:12
@sheremet-va sheremet-va added this to the 2.2.0 milestone Oct 29, 2024
@sheremet-va sheremet-va merged commit 697c35c into vitest-dev:main Nov 13, 2024
17 checks passed
@sheremet-va sheremet-va deleted the feat/add-message-to-skip branch November 13, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for ctx.todo()
1 participant