Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only use locator.element on last expect.element attempt (fix #7139) #7152

Merged
merged 7 commits into from
Jan 3, 2025
Merged

fix: only use locator.element on last expect.element attempt (fix #7139) #7152

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c35f89d
fix: only use locator.element on last expect.element attempt (fix #7139)
tsirlucas Dec 31, 2024
2cc9d40
chore: fix lint errors
tsirlucas Dec 31, 2024
03458b5
chore: bump number of tests on runner.test.ts
tsirlucas Dec 31, 2024
db53172
pr review fixes
tsirlucas Jan 3, 2025
1a3f861
remove unneeded blank line
tsirlucas Jan 3, 2025
4ade736
remove async/await in favor of promise.then
tsirlucas Jan 3, 2025
e1fb0d9
reject with catch error as cause
tsirlucas Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/browser/specs/runner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ describe('running browser tests', async () => {
console.error(stderr)
})

expect(browserResultJson.testResults).toHaveLength(19 * instances.length)
expect(passedTests).toHaveLength(17 * instances.length)
expect(browserResultJson.testResults).toHaveLength(20 * instances.length)
Copy link
Contributor Author

@tsirlucas tsirlucas Dec 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct? i assumed i needed to bump those since i added new test cases

if thats the case, maybe its a good idea to leave a comment here saying its fine to bump it if you added new tests... i can do it in scope of this PR if you want

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are correct. Feel free to add a comment

expect(passedTests).toHaveLength(18 * instances.length)
expect(failedTests).toHaveLength(2 * instances.length)

expect(stderr).not.toContain('optimized dependencies changed')
Expand Down
Loading