Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new "me" command to download by liked albums/tracks #185

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

iamABH
Copy link

@iamABH iamABH commented Jan 2, 2023

Hello !

I just added a new "me" command to download by liked albums/tracks.

I also manage the offset / limit pagination in Qobuz API on this command.

The endpoint "favorite/getUserFavorites" was already implemented in the Qobuz Client and I tweaked it a little bit to implement tracks type too.

Let me know if there is any issues.

@iamABH iamABH mentioned this pull request Jan 3, 2023
@vitiko98
Copy link
Owner

Hey, thanks for this PR! And sorry for the late reply...

Sadly, I can't test it right now (I don't have any Qobuz account). I'd just merge it if it was a small change, but this PR would make substantial changes to core and qopy.

I'll try to get a subscription as soon as possible.

@iamABH
Copy link
Author

iamABH commented Mar 6, 2023

No problem, keep me informed :)

@GlacierIsland
Copy link

Would really appreciate this merge; would make the script a lot more useful for me.

Copy link

@melindafunk melindafunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small issue with default

qobuz_dl/core.py Outdated
@@ -41,6 +42,7 @@ def __init__(
embed_art=False,
lucky_limit=1,
lucky_type="album",
me_type="album",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be albums

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed ! Thanks for reviewing this :)

"-t",
"--type",
default="album",
help=("type of items to search (albums, tracks) (default: album)"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default: albums

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already fixed in newest commits

@iamABH
Copy link
Author

iamABH commented Oct 12, 2023

Any plan to merge this ? @vitiko98 :)

@fc7 fc7 mentioned this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants