Tabs : error javascript on refresh

[zamrokk]

w2ui-1.3.js line 7267

stack :
Uncaught TypeError: Cannot read property 'id' of undefined w2ui-1.3.js:7282
w2tabs.refresh w2ui-1.3.js:7282
w2tabs.refresh w2ui-1.3.js:7261
w2tabs.render w2ui-1.3.js:7328
$j.fn.w2tabs w2ui-1.3.js:7096
(anonymous function) notifications.jsp:399
fire jquery-2.0.2.js:2939
self.fireWith jquery-2.0.2.js:3051
jQuery.extend.ready jquery-2.0.2.js:398
completed

i replaced this :

// create or refresh only one item
var tab = this.get(id);
if (tab == null) return;

by this :

// create or refresh only one item
var tab = this.get(id);
if (id == null) return;

it works fine now

i am using with prototype.js and jquery noConflict mode. I had to rename all $ on w2ui to $j. Is not a better solution for w2ui for replacing $ variable as jquery does ?

Can you send me back a comment on my fix ?

Thanks

[vitmalina]

I have tried to replicate the problem but could not. Can you see if this happens without the use of other libraries besides jQuery. About your fix, it does not seem to look correct. The parameter id can be passed as undefined and you are only checking for null. However, this.get(id) will return null or an object.

[zamrokk]

in my case, when i had the original version

var tab = this.get(id);
if (tab == null) return;

i had values : id = null and tab = undefined
it was at the end of the construction of tabulations. From #1 to #3 tabs was ok, Then it comes back to the caller of recursive loop (for (var i in this.tabs) this.refresh(this.tabs[i].id);) and javascript fails as i said.

Only rescue was to check on id==null

[vitmalina]

I still have hard time replication. Can you post code sample? Is it reproducible without other libraries?

[zamrokk]

i will try to come back to you ASAP
at the moment my PM has asked me to fix bugs on another project.

[zamrokk]

i removed prototype.js and i don't have any errors now.

Is hardly maintainable to keep prototype and jquery on same project. I made some library cleaning on same time.