Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leverage caching for rendering traces #198

Merged
merged 1 commit into from
Jun 29, 2022
Merged

leverage caching for rendering traces #198

merged 1 commit into from
Jun 29, 2022

Conversation

vito
Copy link
Owner

@vito vito commented Jun 28, 2022

previously it was possible to load a cached file and run it without a runtime but then fail to render its content in the trace printed to stderr:

error! call trace (oldest first):

   ┆ <fs>/project.bass:35:2..35:45
35 │   (github:check-hook event client git checks))
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

   ┆ <thunk: (.git) name:yPieviqhlsa6uTBhT-gpoQDbzpMyl1owqphA_l6wt0Y=>/bass/github.bass:3:4..54:66
   ! could not open frame source: no runtime configured for os=linux, arch=any

   ┆ (6 internal calls elided)
   ┆ <thunk: (.git) name:yPieviqhlsa6uTBhT-gpoQDbzpMyl1owqphA_l6wt0Y=>/bass/github.bass:5:6..17:68
   ! could not open frame source: no runtime configured for os=linux, arch=any

   ┆ (6 internal calls elided)
   ┆ <thunk: (.git) name:yPieviqhlsa6uTBhT-gpoQDbzpMyl1owqphA_l6wt0Y=>/bass/github.bass:9:8..9:71
   ! could not open frame source: no runtime configured for os=linux, arch=any

   ┆ <thunk: (.git) name:yPieviqhlsa6uTBhT-gpoQDbzpMyl1owqphA_l6wt0Y=>/bass/github.bass:57:4..59:27
   ! could not open frame source: no runtime configured for os=linux, arch=any

no runtime configured for os=linux, arch=any

live example here

now if it's able to get that far it'll use the cached file for rendering the actual code too.

previously it was possible to load a cached file and run it without a
runtime but then fail to render its content in the trace printed to
stderr:

    error! call trace (oldest first):

       ┆ <fs>/project.bass:35:2..35:45
    35 │   (github:check-hook event client git checks))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

       ┆ <thunk: (.git) name:yPieviqhlsa6uTBhT-gpoQDbzpMyl1owqphA_l6wt0Y=>/bass/github.bass:3:4..54:66
       ! could not open frame source: no runtime configured for os=linux, arch=any

       ┆ (6 internal calls elided)
       ┆ <thunk: (.git) name:yPieviqhlsa6uTBhT-gpoQDbzpMyl1owqphA_l6wt0Y=>/bass/github.bass:5:6..17:68
       ! could not open frame source: no runtime configured for os=linux, arch=any

       ┆ (6 internal calls elided)
       ┆ <thunk: (.git) name:yPieviqhlsa6uTBhT-gpoQDbzpMyl1owqphA_l6wt0Y=>/bass/github.bass:9:8..9:71
       ! could not open frame source: no runtime configured for os=linux, arch=any

       ┆ <thunk: (.git) name:yPieviqhlsa6uTBhT-gpoQDbzpMyl1owqphA_l6wt0Y=>/bass/github.bass:57:4..59:27
       ! could not open frame source: no runtime configured for os=linux, arch=any

    no runtime configured for os=linux, arch=any

now if it's able to get that far it'll use the cached file for rendering
the actual code, too.
@vito vito added the enhancement New feature or request label Jun 28, 2022
@vito vito merged commit f1cf953 into main Jun 29, 2022
@vito vito deleted the cache-traces branch June 29, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant