duplicate concat as a replacement for append

bass/shipit

@@ -59,7 +59,7 @@
   (let [bins (all-bins src tag)
         archives (vals bins)
         repros (reduce-kv (fn [acc k v] (cons (archive-repro k v) acc)) [] bins)
-        files (append archives repros)
+        files (concat archives repros)
         sums (mkfile ./sha256sums.txt (sha256sums src files))]
     (bass:smoke-test bins:linux-amd64)
     (conj files sums)))

pkg/bass/ground_test.go

@@ -2008,6 +2008,18 @@ func TestGroundList(t *testing.T) {
 				bass.Int(6),
 			),
 		},
+		{
+			Name: "concat",
+			Bass: "(concat [1 2] [3 4 5] [6])",
+			Result: bass.NewList(
+				bass.Int(1),
+				bass.Int(2),
+				bass.Int(3),
+				bass.Int(4),
+				bass.Int(5),
+				bass.Int(6),
+			),
+		},
 		{
 			Name: "filter",
 			Bass: "(filter symbol? [1 :two 3 :four 5 :six])",

std/root.bass

@@ -214,23 +214,26 @@
     [] z
     [x & xs'] (foldl f (f z x) xs')))
 
-(provide (append)
-  (defn append1 [xs ys]
+(provide (concat)
+  (defn concat1 [xs ys]
     (case xs
       [] ys
-      [x & xs'] (cons x (append1 xs' ys))))
+      [x & xs'] (cons x (concat1 xs' ys))))
 
   ; joins all given lists into one list
   ;
-  ; => (append [1] [2 3] [4 5 6])
-  (defn append xss
-    (foldl append1 [] xss)))
+  ; => (concat [1] [2 3] [4 5 6])
+  (defn concat xss
+    (foldl concat1 [] xss)))
+
+^{:deprecated "Use (concat) instead."}
+(def append concat)
 
 ; returns only values from xs which satisfy the predicate
 ;
 ; => (filter symbol? [:abc 123 :def "456"])
 (defn filter [predicate xs]
-  (apply append (map (fn [x] (if (predicate x) [x] [])) xs)))
+  (apply concat (map (fn [x] (if (predicate x) [x] [])) xs)))
 
 ; conjoins values onto the end of a list
 ;

std/run.bass

@@ -67,7 +67,7 @@
 (defn wrap-cmd [thunk cmd & args]
   (-> thunk
       (with-cmd cmd)
-      (with-args (append args (cons (thunk-cmd thunk)
+      (with-args (concat args (cons (thunk-cmd thunk)
                                     (thunk-args thunk))))))
 
 (provide [linux]