fix: runner url in contributing.md #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had this strange error trying to run the runner for a PR:
```
15:56:33.469 error failed to connect {"error": "dial tcp: lookup github.bass-loop.org on ....1:53: no such host"}
dial: 1 error occurred:
* dial tcp: lookup github.bass-loop.org on ...1:53: no such host
```
Looks like the url wasn't correct in the example.
5 tasks
|
Whoops, nice catch. Thanks! Not sure why all the builds failed for this. Was the |
|
I had the runner in the foreground, when I realized it wasn't going to pickup the commits from #242 I killed it without realizing it was running these. If I remember correctly the output only shows the health checks/keep alive pings from the server, but I didn't see any "currently running ..." so I didn't realize it was running jobs 😬. |
|
Yeah true, I've been thinking of having it show all the output for everything it's running. It's definitely a bit too quiet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this strange error trying to run the runner for a PR:
Looks like the url wasn't correct in the example.