add Dagger runtime #259
Merged
add Dagger runtime #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vito
force-pushed
the
dagger
branch
2 times, most recently
from
6c12d2a
to
c805b2d
Compare
simpler this way, keeps in sync with dagger which needs stable version
* fix exec'ing before mounts are added * support thunk dir * support thunk env * support mounting thunk files * support mounting fspaths
this was a temporary measure, will just use config now
repl had no pool, flag-only commands wouldn't run
knew this would backfire immediately
totally not worth trying to do the old engine stuff anymore now that the engine runs in a separate image with special OCI runtimes and etc.
can probably do this by running a dagger session in bass once we figure that out
this was caused by the need to hook up a progress sink as soon as creating the Dagger runtime, rather than on each call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new Dagger runtime alongside the existing Buildkit runtime.
Note that this isn't yet feature complete, but I'd like to merge what's done so far. Dagger has proven to be a perfect for this, aside from the missing functionality. The runtime implementation is tiny!
To use the Dagger runtime, add this to
~/.config/bass/config.json:{ "runtimes": [ { "platform": {"os": "linux"}, "runtime": "dagger" } ] }All the basics are implemented and tested, but there are substantial things missing:
Each of these has a corresponding failing runtime test. The tests are skipped for now in CI.
The Buildkit runtime will stick around, and will remain tested with the same rigor - the shared runtime suite is very handy for that! Someday though it might make sense for the Dagger runtime to become the default, since Dagger will receive a lot of investment in out-of-the-box ease-of-use that Buildkit is unlikely to receive. We'll see how it goes.