auto-rotate expired TLS certs, refactor test setup #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
vito
commented
Nov 27, 2022
vito
commented
- don't commit test TLS certs to repo, generate on-the-fly instead
- tests started failing because the committed certs expired (duh)
- rotate local depot certs automatically
- refactor secrets/interruption tests to match the rest of the test setup
- misc test cleanups/fixes
these all share a session, so mutating *stdin* from the loaded module would result in the second test failing
previously progress output wasn't being captured and displayed by failing Dagger tests because for Dagger the progress is emitted at the pool-level, which was constructed ahead of the progress UI being wired up. this simplifies the individual runtime tests since they just need to pass a single runtime config in, but I'd still prefer to not have a monolithic progress sink. oh well. maybe that'll improve when we figure out the progress API in Dagger.
* generate tls certs on every suite run * remove static tls certs which were also installed into docker container * tests create their own installation with the generated cert instead note that the cert being out of date isn't detected; you'll need to docker rm -f the test container still
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.