Dagger runtime: services, stable timestamps, locked cache access #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vito
force-pushed
the
dagger-services
branch
from
ada68fb
to
16852c2
Compare
should be configurable in the future, just matching Buildkit runtime and making test pass in the process
vito
force-pushed
the
dagger-services
branch
from
16852c2
to
2e20dfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WithTimestampsso thunk paths have the same stable timestamp guarantees as with the Buildkit runtime.Lockedsynchronization for cache paths.Just four failing Dagger runtime tests to go! (Cache subpaths, secrets, OCI image archives, and TLS.)