forked from sonic-net/sonic-buildimage
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mellanox] Facilitate automatic integration of new hw-mgmt #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekrnv
force-pushed
the
master_intg_hw_mgmt
branch
10 times, most recently
from
March 18, 2023 02:46
4ae21c5
to
5d61ab7
Compare
8 tasks
vivekrnv
force-pushed
the
master_intg_hw_mgmt
branch
5 times, most recently
from
March 20, 2023 18:13
35d763e
to
e5c7cc1
Compare
dgsudharsan
requested changes
Mar 21, 2023
vivekrnv
force-pushed
the
master_intg_hw_mgmt
branch
from
March 21, 2023 20:14
e5c7cc1
to
179247c
Compare
vivekrnv
force-pushed
the
master_intg_hw_mgmt
branch
from
March 21, 2023 23:03
179247c
to
3874307
Compare
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
This reverts commit f15d6fd.
This reverts commit 5223a78.
This reverts commit 6df9d54.
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
vivekrnv
changed the title
Integrated hw-mgmt automation script into SONiC
[mellanox] Facilitate automatic integration of new hw-management version
Mar 30, 2023
vivekrnv
changed the title
[mellanox] Facilitate automatic integration of new hw-management version
[mellanox] Facilitate automatic integration of new hw-mgmt
Mar 31, 2023
dgsudharsan
requested changes
Apr 1, 2023
dgsudharsan
requested changes
Apr 3, 2023
platform/mellanox/integration-scripts/tests/data/expected_data/series.patch
Outdated
Show resolved
Hide resolved
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Handled all the comments, updated description to document limitations and update makefile to only commit when there are changes |
dgsudharsan
requested changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the remaining unresolved comments
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Addressed |
dgsudharsan
approved these changes
Apr 4, 2023
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
vivekrnv
pushed a commit
that referenced
this pull request
Sep 23, 2023
…ly (sonic-net#16566) #### Why I did it src/dhcprelay ``` * 2b33d76 - (HEAD -> master, origin/master, origin/HEAD) dhcpv6 per interface counter support (#43) (7 days ago) [jcaiMR] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Facilitate Automatic integration of new hw-mgmt version into SONiC.
Inputs to the Script:
MLNX_HW_MANAGEMENT_VERSION
Eg:7.0040.5202
CREATE_BRANCH: (y|n)
Creates a branch instead of a commit (optional, default: n)BRANCH_SONIC
: Only relevant when CREATE_BRANCH is y.Default: master
.Note: These should be provided through
SONIC_OVERRIDE_BUILD_VARS
parameterOutput:
MLNX_HW_MANAGEMENT_VERSION
Brief Summary of the changes made:
MLNX_HW_MANAGEMENT_VERSION
flag in the hw-management.mk file<branch>_<parent_commit>_integrate_<hw_mgmt_version>
How I did it
make integrate-mlnx-hw-mgmt
Changes made will be summarized under
sonic-buildimage/integrate-mlnx-hw-mgmt_user.out
file. Debugging and troubleshooting output is written tosonic-buildimage/integrate-mlnx-hw-mgmt.log
filesJenkins output file:
http://nbu-nfs.mellanox.com/auto/mtrsysgwork/vkarri/integrate-mlnx-hw-mgmt_user.out
stdout for debugging:
http://nbu-nfs.mellanox.com/auto/mtrsysgwork/vkarri/integrate-mlnx-hw-mgmt.log
Limitations:
How to verify it
Build the Kernel
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)