Skip to content

Commit

Permalink
Remove @comet/admin-react-select (#2949)
Browse files Browse the repository at this point in the history
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
  • Loading branch information
manuelblum and johnnyomair authored Dec 19, 2024
1 parent b374300 commit 908d799
Show file tree
Hide file tree
Showing 30 changed files with 37 additions and 1,738 deletions.
5 changes: 5 additions & 0 deletions .changeset/nasty-peaches-relax.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin-react-select": major
---

Remove `@comet/admin-react-select` package
43 changes: 4 additions & 39 deletions dev-pm.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ const packageFolderMapping = {
"@comet/admin-color-picker": "packages/admin/admin-color-picker",
"@comet/admin-date-time": "packages/admin/admin-date-time",
"@comet/admin-icons": "packages/admin/admin-icons",
"@comet/admin-react-select": "packages/admin/admin-react-select",
"@comet/admin-rte": "packages/admin/admin-rte",
"@comet/admin-theme": "packages/admin/admin-theme",
"@comet/blocks-admin": "packages/admin/blocks-admin",
Expand Down Expand Up @@ -42,12 +41,6 @@ module.exports = {
script: "pnpm --filter @comet/admin-icons run start",
group: ["comet-admin"],
},
{
name: "comet-admin-react-select",
script: "pnpm --filter @comet/admin-react-select run start",
group: ["comet-admin"],
waitOn: waitOnPackages("@comet/admin"),
},
{
name: "comet-admin-rte",
script: "pnpm --filter @comet/admin-rte run start",
Expand All @@ -57,13 +50,7 @@ module.exports = {
name: "comet-admin-theme",
script: "pnpm --filter @comet/admin-theme run start",
group: ["comet-admin"],
waitOn: waitOnPackages(
"@comet/admin-icons",
"@comet/admin-rte",
"@comet/admin",
"@comet/admin-color-picker",
"@comet/admin-react-select",
),
waitOn: waitOnPackages("@comet/admin-icons", "@comet/admin-rte", "@comet/admin", "@comet/admin-color-picker"),
},

// group cms-admin
Expand All @@ -83,40 +70,19 @@ module.exports = {
name: "cms-admin",
script: "pnpm --filter @comet/cms-admin run start",
group: ["cms-admin", "cms"],
waitOn: waitOnPackages(
"@comet/admin",
"@comet/admin-icons",
"@comet/admin-react-select",
"@comet/admin-rte",
"@comet/admin-theme",
"@comet/blocks-admin",
),
waitOn: waitOnPackages("@comet/admin", "@comet/admin-icons", "@comet/admin-rte", "@comet/admin-theme", "@comet/blocks-admin"),
},
{
name: "cms-admin-codegen-graphql-types",
script: "pnpm --filter @comet/cms-admin run generate-graphql-types:watch",
group: ["cms-admin", "cms"],
waitOn: waitOnPackages(
"@comet/admin",
"@comet/admin-icons",
"@comet/admin-react-select",
"@comet/admin-rte",
"@comet/admin-theme",
"@comet/blocks-admin",
),
waitOn: waitOnPackages("@comet/admin", "@comet/admin-icons", "@comet/admin-rte", "@comet/admin-theme", "@comet/blocks-admin"),
},
{
name: "cms-admin-codegen-block-types",
script: "pnpm --filter @comet/cms-admin run generate-block-types:watch",
group: ["cms-admin", "cms"],
waitOn: waitOnPackages(
"@comet/admin",
"@comet/admin-icons",
"@comet/admin-react-select",
"@comet/admin-rte",
"@comet/admin-theme",
"@comet/blocks-admin",
),
waitOn: waitOnPackages("@comet/admin", "@comet/admin-icons", "@comet/admin-rte", "@comet/admin-theme", "@comet/blocks-admin"),
},

//group cms-api
Expand Down Expand Up @@ -157,7 +123,6 @@ module.exports = {
...waitOnPackages(
"@comet/admin",
"@comet/admin-icons",
"@comet/admin-react-select",
"@comet/admin-rte",
"@comet/admin-theme",
"@comet/blocks-admin",
Expand Down
15 changes: 15 additions & 0 deletions docs/docs/migration/migration-from-v7-to-v8.md
Original file line number Diff line number Diff line change
Expand Up @@ -291,3 +291,18 @@ The recommended way to handle errors is to use the `ErrorBoundary` in the parent
+ }
+ <DataGrid /* other props */ >
```

### Remove @comet/admin-react-select

```diff
- "@comet/admin-react-select": "^7.x.x",
```

It is recommended to use the `AutocompleteField` or the `SelectField` components from `@comet/admin` instead:

```diff
- import { FinalFormReactSelectStaticOptions } from "@comet/admin-react-select";
- <Field name="color" type="text" component={FinalFormReactSelectStaticOptions} fullWidth options={options} />;
+ import { AutocompleteField } from "@comet/admin";
+ <AutocompleteField name="color" label="Color" options={options} fullWidth />;
```
4 changes: 0 additions & 4 deletions docs/docs/overview/packages-tools.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ A complete list of the admin-icons can be found here: [Storybook](https://comet-

Provides a customizable rich-text-editor component to allow advanced formatting of text.

#### @comet/admin-react-select

Provides a set of select components for use in forms, built with react-final-form.

#### @comet/admin-date-time

Provides components for selecting date and time or a range or combination of date and time.
Expand Down
1 change: 0 additions & 1 deletion docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"@comet/admin-color-picker": "workspace:*",
"@comet/admin-date-time": "workspace:*",
"@comet/admin-icons": "workspace:*",
"@comet/admin-react-select": "workspace:*",
"@comet/admin-rte": "workspace:*",
"@comet/admin-theme": "workspace:*",
"@docusaurus/core": "2.4.1",
Expand Down
5 changes: 0 additions & 5 deletions docs/src/theme/ReactLiveScope/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ if (ExecutionEnvironment.canUseDOM) {
const cometAdminDateTimeImports = require("@comet/admin-date-time");
const { Toolbar, ...cometAdminRteImports } = require("@comet/admin-rte");
const cometAdminColorPickerImports = require("@comet/admin-color-picker");
const cometAdminReactSelectImports = require("@comet/admin-react-select");
const cometAdminThemeImports = require("@comet/admin-theme");
const { Card, CardContent, FormControlLabel, Grid, Chip, IconButton, Typography, Box } = require("@mui/material");
const { Form } = require("react-final-form");
Expand Down Expand Up @@ -76,10 +75,6 @@ if (ExecutionEnvironment.canUseDOM) {
name: "@comet/admin-color-picker",
imports: cometAdminColorPickerImports,
},
{
name: "@comet/admin-react-select",
imports: cometAdminReactSelectImports,
},
{
name: "@comet/admin-theme",
imports: cometAdminThemeImports,
Expand Down
4 changes: 0 additions & 4 deletions knip.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@
"entry": ["./src/index.ts"],
"project": ["./src/**/*.{ts,tsx}"]
},
"packages/admin/admin-react-select": {
"entry": ["./src/index.ts"],
"project": ["./src/**/*.{ts,tsx}"]
},
"packages/admin/admin-rte": {
"entry": ["./src/index.ts"],
"project": ["./src/**/*.{ts,tsx}"]
Expand Down
3 changes: 0 additions & 3 deletions packages/admin/admin-react-select/.babelrc.json

This file was deleted.

19 changes: 0 additions & 19 deletions packages/admin/admin-react-select/.eslintrc.json

This file was deleted.

1 change: 0 additions & 1 deletion packages/admin/admin-react-select/.npmignore

This file was deleted.

1 change: 0 additions & 1 deletion packages/admin/admin-react-select/.prettierignore

This file was deleted.

Loading

0 comments on commit 908d799

Please sign in to comment.