Prevent Data Grids with the same name to overwrite each others pinned and column-visibility states #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…others pinned state
jamesricky
reviewed
Sep 26, 2024
johnnyomair
reviewed
Sep 26, 2024
There was a problem hiding this comment.
As discussed internally, please use useRouteMatch instead of window.location
jamesricky
reviewed
Oct 1, 2024
johnnyomair
changed the title
johnnyomair
reviewed
Oct 1, 2024
|
@nsams please review |
jamesricky
approved these changes
Oct 8, 2024
nsams
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug in the
usePersistentColumnStatehook that caused Datagrids with the same name to overwrite each others pinned Columns State by adding thewindow.locationas additional identifierExample
Changeset