Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support kB and MB when displaying the size of a file #2823

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Support kB and MB when displaying the size of a file #2823

merged 6 commits into from
Jan 14, 2025

Conversation

fichtnerma
Copy link
Contributor

@fichtnerma fichtnerma commented Nov 25, 2024 •
edited by johnnyomair
Loading

Example

  • I have verified if my change requires an example

Screenshots/screencasts

image

Changeset

  • I have verified if my change requires a changeset

@auto-assign auto-assign bot requested a review from johnnyomair November 25, 2024 18:18
@fichtnerma fichtnerma changed the title Com 1139 support kb and mb when displaying the size of a file in demo COM-139: support kb and mb when displaying the size of a file Nov 25, 2024
@johnnyomair johnnyomair removed the request for review from thomasdax98 December 16, 2024 15:01
nsams
nsams previously approved these changes Dec 17, 2024
View reviewed changes
@johnnyomair johnnyomair changed the title COM-139: support kb and mb when displaying the size of a file Support kB and MB when displaying the size of a file Dec 18, 2024
johnnyomair
johnnyomair previously approved these changes Dec 18, 2024
View reviewed changes
@johnnyomair
Copy link
Collaborator

@fichtnerma please resolve. conflicts

@fichtnerma fichtnerma dismissed stale reviews from johnnyomair and nsams via dd250ca January 11, 2025 18:56
nsams
nsams previously approved these changes Jan 13, 2025
View reviewed changes
johnnyomair
johnnyomair requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block has been removed in next because it isn't used anymore. Could you please add this behavior to the CallToActionBlock instead? Thanks!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@johnnyomair johnnyomair merged commit 77ba36c into main Jan 14, 2025
5 checks passed
@johnnyomair johnnyomair deleted the COM-1139-support-kb-and-mb-when-displaying-the-size-of-a-file-in-demo branch January 14, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasdax98 thomasdax98 thomasdax98 left review comments

@johnnyomair johnnyomair johnnyomair approved these changes

@nsams nsams nsams left review comments

Assignees

@fichtnerma fichtnerma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fichtnerma @johnnyomair @nsams @thomasdax98