Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for base64 encoding in inject-site-configs command #3053

Merged
merged 8 commits into from
Jan 14, 2025

Conversation

fraxachun
Copy link
Contributor

Description

Encoding characters like \ oder $ is tricky if you want to embed them into environment variables or yaml files. I tried to encode regular expressions and could not find a solution without implementing a workaround after decoding. Encoding it into base64 solves this problem in a more generic way.

Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that's needed all the time? If yes, should it be the default behavior?

packages/cli/src/commands/site-configs.ts Outdated Show resolved Hide resolved
@fraxachun fraxachun requested a review from johnnyomair January 13, 2025 08:11
@johnnyomair johnnyomair merged commit 753cd6f into main Jan 14, 2025
5 checks passed
@johnnyomair johnnyomair deleted the site-config-base64 branch January 14, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants