Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pnpm dev command to start demo and it's packages #3058

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jamesricky
Copy link
Contributor

Description

Starting the demo with it's packages is a common use-case when working on core features, having a single command makes this easier.

Starting the demo with it's packages is a common use-case when working
on core features, having a single command makes this easier.
@jamesricky jamesricky requested a review from johnnyomair January 9, 2025 13:51
@jamesricky jamesricky self-assigned this Jan 9, 2025
Copy link

sonarqubecloud bot commented Jan 9, 2025

Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this because devs tend to start everything everywhere all at once when such a script exists, even when they only need one package. But if @thomasdax98 approves it, I'm fine with it.

@jamesricky
Copy link
Contributor Author

I don't like this because devs tend to start everything everywhere all at once when such a script exists, even when they only need one package. But if @thomasdax98 approves it, I'm fine with it.

I see your point but I prefer to have something unnecessarily running in the background sometimes over trying to understand why my changes aren't working sometimes 😅

@johnnyomair
Copy link
Collaborator

I see your point but I prefer to have something unnecessarily running in the background sometimes over trying to understand why my changes aren't working sometimes 😅

If somebody complains that their Mac is running slow, I'll forward them to you 😉

Copy link
Member

@thomasdax98 thomasdax98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly about this. Sometimes you want to start everything, then this helps you. If you carelessly start everything, then it's your own fault.

So it's fine by me

@johnnyomair johnnyomair merged commit 81791a1 into main Jan 15, 2025
13 checks passed
@johnnyomair johnnyomair deleted the run-dev-command-for-all-packages branch January 15, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants