Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent router prompt when using a block with subroutes in a form #3281

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

johnnyomair
Copy link
Collaborator

Description

In #1955 we introduced the concept of a ForcePromptRoute to force a prompt when navigating into a nested stack. However, this behavior isn't desired when using a block with subroutes (e.g., a BlocksBlock) in a form. We fix this by adding a disableForcePromptRoute option to StackSwitch to disable the behavior for stacks used in blocks.

Acceptance criteria

Further information

@johnnyomair johnnyomair requested a review from nsams January 28, 2025 13:52
@johnnyomair johnnyomair self-assigned this Jan 28, 2025
@johnnyomair johnnyomair merged commit bd562d3 into main Jan 28, 2025
11 checks passed
@johnnyomair johnnyomair deleted the block-in-final-form branch January 28, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants