[plugin-rest-api] Add extended logging for HTTP requests and responses #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4537 +/- ##
============================================
+ Coverage 97.31% 97.40% +0.08%
- Complexity 6439 6513 +74
============================================
Files 894 912 +18
Lines 18570 18740 +170
Branches 1238 1249 +11
============================================
+ Hits 18072 18253 +181
+ Misses 389 381 -8
+ Partials 109 106 -3 ☔ View full report in Codecov by Sentry. |
valfirst
requested changes
Nov 6, 2023
vividus-plugin-rest-api/src/main/java/org/vividus/http/ExtendedHttpLoggingInterceptor.java
Outdated
Show resolved
Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/ExtendedHttpLoggingInterceptor.java
Show resolved
Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/ExtendedHttpLoggingInterceptor.java
Outdated
Show resolved
Hide resolved
draker94
force-pushed
the
add_http_extended_logging
branch
from
ae1d87c to
1b31dc8
Compare
uarlouski
reviewed
Nov 8, 2023
vividus-plugin-rest-api/src/main/java/org/vividus/http/ExtendedHttpLoggingInterceptor.java
Outdated
Show resolved
Hide resolved
uarlouski
reviewed
Nov 8, 2023
vividus-plugin-rest-api/src/main/java/org/vividus/http/ExtendedHttpLoggingInterceptor.java
Show resolved
Hide resolved
uarlouski
reviewed
Nov 8, 2023
vividus-plugin-rest-api/src/main/java/org/vividus/http/ExtendedHttpLoggingInterceptor.java
Outdated
Show resolved
Hide resolved
uarlouski
reviewed
Nov 8, 2023
vividus-plugin-rest-api/src/main/java/org/vividus/http/ExtendedHttpLoggingInterceptor.java
Outdated
Show resolved
Hide resolved
draker94
force-pushed
the
add_http_extended_logging
branch
3 times, most recently
from
fa009d6 to
b00fe66
Compare
valfirst
requested changes
Nov 10, 2023
vividus-plugin-rest-api/src/main/resources/properties/defaults/default.properties
Show resolved
Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/PublishingAttachmentInterceptor.java
Outdated
Show resolved
Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/ExtendedHttpLoggingInterceptor.java
Outdated
Show resolved
Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/ExtendedHttpLoggingInterceptor.java
Outdated
Show resolved
Hide resolved
valfirst
reviewed
Nov 10, 2023
vividus-plugin-rest-api/src/main/java/org/vividus/http/ExtendedHttpLoggingInterceptor.java
Outdated
Show resolved
Hide resolved
valfirst
requested changes
Nov 10, 2023
vividus-plugin-rest-api/src/main/java/org/vividus/http/MimeTypeUtils.java
Show resolved
Hide resolved
vividus-plugin-rest-api/src/main/resources/vividus-plugin/spring.xml
Outdated
Show resolved
Hide resolved
draker94
force-pushed
the
add_http_extended_logging
branch
from
b00fe66 to
c9a5fe6
Compare
valfirst
approved these changes
Nov 27, 2023
uarlouski
reviewed
Nov 28, 2023
| } | ||
| else if (entity != null) | ||
| { | ||
| int bodySizeInBytes = entity.getContent().available(); |
There was a problem hiding this comment.
getContentLength
Entities can be created without explicitly specifying length:
https://github.com/apache/httpcomponents-core/blob/master/httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/BasicHttpEntity.java#L67-L69
So I think it's safer to take the length right from the content
uarlouski
reviewed
Nov 28, 2023
vividus-plugin-rest-api/src/main/java/org/vividus/http/ExtendedHttpLoggingInterceptor.java
Outdated
Show resolved
Hide resolved
draker94
force-pushed
the
add_http_extended_logging
branch
from
c9a5fe6 to
df6fcc1
Compare
uarlouski
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4437