[plugin-web-app-to-rest-api] Add ability to use variable name as HTML… #4652
+107
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested changes
Dec 8, 2023
| |The URL of the page to build the table upon. | ||
| a|The URL of the page to build the table upon. | ||
|
|
||
| WARNING: The `pageUrl` parameter is deprecated, please use `variableName` instead. |
There was a problem hiding this comment.
need to provide a version, when pageUrl is going to be removed
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
… source in from_html transformer
uarlouski
force-pushed
the
feature/html-transformer-variable
branch
from
9ed8657 to
176fa1c
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4652 +/- ##
============================================
+ Coverage 97.38% 97.39% +0.01%
- Complexity 6526 6534 +8
============================================
Files 914 914
Lines 18789 18798 +9
Branches 1249 1251 +2
============================================
+ Hits 18298 18309 +11
+ Misses 384 383 -1
+ Partials 107 106 -1 ☔ View full report in Codecov by Sentry. |
valfirst
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… source in from_html transformer