[vividus-engine] Fix logging of deprecated steps without parameters inside composite steps #4682
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4682 +/- ##
============================================
+ Coverage 97.39% 97.40% +0.01%
- Complexity 6525 6566 +41
============================================
Files 914 917 +3
Lines 18786 18876 +90
Branches 1251 1254 +3
============================================
+ Hits 18297 18387 +90
Misses 383 383
Partials 106 106 ☔ View full report in Codecov by Sentry. |
| Matcher stepMatcher = getStepMatcher(runningDeprecatedStep); | ||
| String[] stepParams = getParametersFromStep(stepMatcher); | ||
| Optional<Matcher> stepMatcher = getStepMatcher(runningDeprecatedStep); | ||
| String[] stepParams = stepMatcher.map(this::getParametersFromStep).orElseGet(() -> new String[0]); |
There was a problem hiding this comment.
that's a fix of the reason, but not root cause, any plans to do root cause analysis?
There was a problem hiding this comment.
that's a fix of the reason, but not root cause, any plans to do root cause analysis?
The root of the problem is that steps within composite steps can be processed by separate logic (without using stepMonitor which we use to collect patterns of the current steps from tests) on the JBehave side.
https://github.com/jbehave/jbehave-core/blob/9510692f56f31551aa52e0eeddc03cc426deaea5/jbehave-core/src/main/java/org/jbehave/core/steps/StepCandidate.java#L242-L243
I'll think about how to make the "monitoring" of matched steps more unified on the JBehave side.
…nside composite steps
draker94
force-pushed
the
fix_logging_of_deprecated_composed_steps
branch
from
e6b369e to
5375062
Compare
draker94
changed the title
Closes #4680