Extend headless and sitemap transformers to pass app URL through transformer parameter #4725
Conversation
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
uarlouski
force-pushed
the
feature/flexible-transformer-config
branch
from
435fdd0 to
bd456d5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4725 +/- ##
============================================
+ Coverage 97.41% 97.42% +0.01%
+ Complexity 6812 6579 -233
============================================
Files 916 916
Lines 18923 18939 +16
Branches 1260 1261 +1
============================================
+ Hits 18433 18451 +18
+ Misses 383 382 -1
+ Partials 107 106 -1 ☔ View full report in Codecov by Sentry. |
uarlouski
force-pushed
the
feature/flexible-transformer-config
branch
from
bd456d5 to
e9b0a63
Compare
uarlouski
changed the title
| | | ||
| a|main application page URL, used as initial seed URL that is fetched by the crawler to extract new URLs in it and follow them for crawling. | ||
|
|
||
| IMPORTANT: The main page url value defined by this property gets overriden by the value defined in `mainPageUrl` transformer parameter. |
There was a problem hiding this comment.
| IMPORTANT: The main page url value defined by this property gets overriden by the value defined in `mainPageUrl` transformer parameter. | |
| IMPORTANT: The main page URL value defined by this property gets overriden by the value defined in `mainPageUrl` transformer parameter. |
| + "be removed in VIVIDUS 0.7.0, pelase see official documentation for corresponding" | ||
| + " replacements."); |
There was a problem hiding this comment.
it's better to provide replacement options right, instead of asking users to search for the documentation
There was a problem hiding this comment.
well its easy to describe transformer parameter but when it comes to property name we will have it pass from child classes making it clumsy
uarlouski
force-pushed
the
feature/flexible-transformer-config
branch
from
e9b0a63 to
b4168bc
Compare
…sformer parameter
uarlouski
force-pushed
the
feature/flexible-transformer-config
branch
from
b4168bc to
3d53f54
Compare
...-api/src/main/java/org/vividus/crawler/transformer/AbstractFetchingUrlsTableTransformer.java
Outdated
Show resolved
Hide resolved
...-api/src/main/java/org/vividus/crawler/transformer/AbstractFetchingUrlsTableTransformer.java
Outdated
Show resolved
Hide resolved
|
No description provided.