Consider sticky header size when scrolling element into view #4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
valfirst
reviewed
Feb 12, 2024
vividus-plugin-web-app/src/main/java/org/vividus/steps/ui/web/ScrollSteps.java
Show resolved
Hide resolved
uarlouski
force-pushed
the
feature/scroll-into-view-center
branch
from
25f2554 to
3ae88e6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4819 +/- ##
============================================
- Coverage 97.37% 97.36% -0.02%
- Complexity 6585 6820 +235
============================================
Files 917 917
Lines 19015 19015
Branches 1270 1270
============================================
- Hits 18516 18514 -2
- Misses 392 393 +1
- Partials 107 108 +1 ☔ View full report in Codecov by Sentry. |
uarlouski
force-pushed
the
feature/scroll-into-view-center
branch
2 times, most recently
from
9063985 to
25e4558
Compare
uarlouski
force-pushed
the
feature/scroll-into-view-center
branch
from
25e4558 to
79137c2
Compare
valfirst
approved these changes
Feb 13, 2024
|
draker94
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #4666