Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-lighthouse] Remove PWA category #5042

Merged
merged 1 commit into from
May 13, 2024

Conversation

valfirst
Copy link
Collaborator

https://github.com/GoogleChrome/lighthouse/releases/tag/v12.0.0:
"As per Chrome’s updated Installability Criteria(https://developer.chrome.com/blog/update-install-criteria), Lighthouse has removed the PWA category (GoogleChrome/lighthouse#15455). For future PWA testing, users will be directed to use the updated PWA documentation: https://developer.chrome.com/docs/devtools/progressive-web-apps/"
@valfirst valfirst requested a review from a team as a code owner May 13, 2024 14:57
Copy link

sonarcloud bot commented May 13, 2024

Copy link

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (c88e08e) to head (0738262).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5042   +/-   ##
=========================================
  Coverage     97.39%   97.40%           
  Complexity     6628     6628           
=========================================
  Files           921      921           
  Lines         19190    19190           
  Branches       1270     1270           
=========================================
+ Hits          18691    18692    +1     
+ Misses          390      389    -1     
  Partials        109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valfirst valfirst merged commit 9f72245 into master May 13, 2024
10 checks passed
@valfirst valfirst deleted the remove-pwa-category-from-lighthouse branch May 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant