Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin-azure-key-vault] Add ability to read property values from Azure KeyVault #5182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[plugin-azure-key-vault] Add ability to read property values from Azure KeyVault #5182

wants to merge 1 commit into from

Conversation

abudevich
Copy link
Contributor

No description provided.

@abudevich abudevich requested a review from a team as a code owner July 3, 2024 07:35
valfirst
valfirst requested changes Jul 3, 2024
View reviewed changes
docs/modules/plugins/pages/plugin-azure-resource-manager.adoc Outdated Show resolved Hide resolved
vividus-engine/src/main/java/org/vividus/configuration/AbstractPropertiesProcessor.java Outdated Show resolved Hide resolved
vividus-plugin-azure-resource-manager/build.gradle Outdated Show resolved Hide resolved
vividus-plugin-azure-resource-manager/build.gradle Outdated Show resolved Hide resolved
vividus-plugin-azure-resource-manager/src/main/resources/vividus-plugin/spring.xml Outdated Show resolved Hide resolved
vividus/src/main/resources/org/vividus/spring-configuration.xml Outdated Show resolved Hide resolved
...r/src/main/resources/META-INF/services/org.vividus.configuration.AbstractPropertiesProcessor Outdated Show resolved Hide resolved
@abudevich abudevich force-pushed the vividus-azure-key-vault-properties branch 7 times, most recently from d0b999d to 11780c8 Compare July 4, 2024 14:54
@abudevich abudevich requested a review from valfirst July 4, 2024 14:55
@abudevich abudevich force-pushed the vividus-azure-key-vault-properties branch 6 times, most recently from f90dacf to 8894a51 Compare July 9, 2024 14:20
valfirst
valfirst requested changes Jul 9, 2024
View reviewed changes
...us-plugin-azure-resource-manager/src/main/java/org/vividus/azure/client/AzureHttpClient.java Outdated Show resolved Hide resolved
...us-plugin-azure-resource-manager/src/main/java/org/vividus/azure/client/AzureHttpClient.java Outdated Show resolved Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java Outdated Show resolved Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java Outdated Show resolved Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java Outdated Show resolved Hide resolved
docs/modules/plugins/pages/plugin-azure-resource-manager.adoc Outdated Show resolved Hide resolved
docs/modules/plugins/pages/plugin-azure-resource-manager.adoc Outdated Show resolved Hide resolved
...ger/src/test/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessorTests.java Outdated Show resolved Hide resolved
vividus/src/main/java/org/vividus/configuration/ConfigurationResolver.java Outdated Show resolved Hide resolved
vividus/src/main/java/org/vividus/configuration/VaultStoredPropertiesProcessor.java Outdated Show resolved Hide resolved
@abudevich abudevich marked this pull request as draft September 13, 2024 14:25
@abudevich abudevich force-pushed the vividus-azure-key-vault-properties branch 2 times, most recently from d1b4dc5 to af601b7 Compare September 13, 2024 14:31
@abudevich abudevich force-pushed the vividus-azure-key-vault-properties branch 5 times, most recently from d2e5046 to 949e7fc Compare September 24, 2024 11:46
@abudevich abudevich force-pushed the vividus-azure-key-vault-properties branch 3 times, most recently from 9f2c652 to 4078900 Compare October 1, 2024 15:17
@abudevich abudevich marked this pull request as ready for review October 1, 2024 15:18
valfirst
valfirst requested changes Oct 2, 2024
View reviewed changes
docs/modules/ROOT/assets/images/azure-key-vault.png Outdated Show resolved Hide resolved
docs/modules/configuration/pages/secrets-management.adoc Outdated Show resolved Hide resolved
docs/modules/plugins/pages/plugin-azure-resource-manager.adoc Outdated Show resolved Hide resolved
docs/modules/plugins/pages/plugin-azure-resource-manager.adoc Outdated Show resolved Hide resolved
docs/modules/plugins/pages/plugin-azure-resource-manager.adoc Outdated Show resolved Hide resolved
docs/modules/plugins/pages/plugin-azure-resource-manager.adoc Outdated Show resolved Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java Outdated Show resolved Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java Outdated Show resolved Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java Outdated Show resolved Hide resolved
...zure-resource-manager/src/main/java/org/vividus/azure/client/AzureResourceManagerClient.java Outdated Show resolved Hide resolved
@abudevich abudevich force-pushed the vividus-azure-key-vault-properties branch 2 times, most recently from 4389314 to c136357 Compare October 2, 2024 12:53
@abudevich abudevich force-pushed the vividus-azure-key-vault-properties branch 6 times, most recently from b8eb72e to eaff0e6 Compare October 3, 2024 08:44
@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.54%. Comparing base (17895a0) to head (eaff0e6).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...onfiguration/AzureKeyVaultPropertiesProcessor.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5182      +/-   ##
============================================
- Coverage     97.63%   97.54%   -0.10%     
- Complexity     7005     7013       +8     
============================================
  Files           969      971       +2     
  Lines         20330    20359      +29     
  Branches       1329     1330       +1     
============================================
+ Hits          19850    19859       +9     
- Misses          368      387      +19     
- Partials        112      113       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abudevich abudevich force-pushed the vividus-azure-key-vault-properties branch from eaff0e6 to aa556e4 Compare October 4, 2024 08:52
valfirst
valfirst requested changes Oct 4, 2024
View reviewed changes
docs/modules/configuration/pages/secrets-management.adoc Outdated Show resolved Hide resolved
docs/modules/plugins/pages/plugin-azure-resource-manager.adoc Outdated Show resolved Hide resolved
docs/modules/plugins/pages/plugin-azure-resource-manager.adoc Outdated Show resolved Hide resolved
docs/modules/plugins/pages/plugin-azure-resource-manager.adoc Outdated Show resolved Hide resolved
...zure-resource-manager/src/main/java/org/vividus/azure/client/AzureResourceManagerClient.java
Comment on lines +109 to +113
Consumer<String> errorCallback = error -> { throw new RuntimeException(error); };
if (softAssert != null)
{
errorCallback = softAssert::recordFailedAssertion;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this logic should be provided by code invoking this method

...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java Outdated Show resolved Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java Outdated Show resolved Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java Outdated Show resolved Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java
client.executeHttpRequest(HttpMethod.GET,
String.format("https://%s%s/secrets/%s?api-version=%s", keyVaultName,
azureEnvironment.getKeyVaultDnsSuffix(), secretName, apiVersion), Optional.empty(),
response -> value[0] = JsonPathUtils.getData(response, "$.value"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client should be updated to use not Consumer, but Function for response body handling

@abudevich abudevich force-pushed the vividus-azure-key-vault-properties branch from aa556e4 to 24f1c45 Compare November 4, 2024 13:53
@abudevich abudevich force-pushed the vividus-azure-key-vault-properties branch from 24f1c45 to 8f9ba4e Compare November 4, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst requested changes

@uarlouski uarlouski Awaiting requested review from uarlouski uarlouski is a code owner automatically assigned from vividus-framework/maintainers

@draker94 draker94 Awaiting requested review from draker94 draker94 is a code owner automatically assigned from vividus-framework/maintainers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abudevich @valfirst