[http-client] Decode credentials for Basic Authentication #5223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5223 +/- ##
============================================
+ Coverage 97.48% 97.49% +0.01%
- Complexity 6856 6899 +43
============================================
Files 947 950 +3
Lines 19812 19899 +87
Branches 1308 1313 +5
============================================
+ Hits 19313 19400 +87
Misses 390 390
Partials 109 109 ☔ View full report in Codecov by Sentry. |
valfirst
reviewed
Jul 17, 2024
vividus-http-client/src/main/java/org/vividus/http/client/HttpClient.java
Show resolved
Hide resolved
draker94
force-pushed
the
decode_unsafe_chars_http_client
branch
from
4af5f0a to
d24aa2e
Compare
draker94
force-pushed
the
decode_unsafe_chars_http_client
branch
from
d24aa2e to
925ce37
Compare
valfirst
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently HttpClient decode all characters except unsafe, but we don't need encoding of such characters when using Basic Auth, so they should be decoded too