[util] Escape path separators in batch variable keys #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested changes
Dec 13, 2024
| @@ -42,6 +42,9 @@ | |||
|
|
|||
| public class PropertyMapper implements IPropertyMapper | |||
| { | |||
| private static final String VARIABLES_PROPERTY_PREFIX = "variables."; | |||
There was a problem hiding this comment.
we can't hardcode it here:
utilmodule should know nothing aboutenginemodule- this adds tight coupling to property naming
please check this: c9197ca
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5597 +/- ##
==========================================
Coverage 97.69% 97.70%
- Complexity 7073 7124 +51
==========================================
Files 984 987 +3
Lines 20536 20662 +126
Branches 1344 1353 +9
==========================================
+ Hits 20063 20188 +125
- Misses 361 363 +2
+ Partials 112 111 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.