Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Localization of VIVO into Serbian (Latin script) #105

Merged
merged 14 commits into from
Apr 21, 2022
Merged

Localization of VIVO into Serbian (Latin script) #105

merged 14 commits into from
Apr 21, 2022

Conversation

VeljkoMaksimovic
Copy link
Contributor

This localization is dependent on changes made to Vitro in this pull request vivo-project/Vitro#250

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VeljkoMaksimovic please, resolve all comments and translate missed properties and files.

@chenejac chenejac requested a review from lidijaivanovic April 6, 2022 07:35
Copy link

@lidijaivanovic lidijaivanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VeljkoMaksimovic please see my comments and try to address some of them.

<http://vivoweb.org/ontology/core#researchAreaOf> <http://www.w3.org/2000/01/rdf-schema#label> "polje istraživanja"@sr-Latn-RS .
<http://vivoweb.org/ontology/core#subjectAreaOf> <http://www.w3.org/2000/01/rdf-schema#label> "polje istraživačke teme"@sr-Latn-RS .
<http://aims.fao.org/aos/geopolitical.owl#populationTotal> <http://www.w3.org/2000/01/rdf-schema#label> "ukupna populacija"@sr-Latn-RS .
<http://aims.fao.org/aos/geopolitical.owl#nationalityFR> <http://www.w3.org/2000/01/rdf-schema#label> "nacionalnostFR"@sr-Latn-RS .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR = Francuska?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The original value was "nationalityFR". Not sure if this should be interpreted as the word "nationality" in French, or as someone With French nationality

<http://purl.org/NET/c4dm/event.owl#Event> <http://www.w3.org/2000/01/rdf-schema#label> "Događaj"@sr-Latn-RS .
<http://purl.org/ontology/bibo/rejected> <http://www.w3.org/2000/01/rdf-schema#label> "odbijeno"@sr-Latn-RS .
<http://aims.fao.org/aos/geopolitical.owl#hasMaxLongitude> <http://www.w3.org/2000/01/rdf-schema#label> "ima maksimalnu geografsku dužinu"@sr-Latn-RS .
<http://aims.fao.org/aos/geopolitical.owl#nationalityEN> <http://www.w3.org/2000/01/rdf-schema#label> "nacionalnostEN"@sr-Latn-RS .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Engleska nacionalnost ili Englez?

<http://vivoweb.org/ontology/core#CaseStudy> <http://www.w3.org/2000/01/rdf-schema#label> "Istraživanje Slučaja"@sr-Latn-RS .
<http://aims.fao.org/aos/geopolitical.owl#populationYear> <http://www.w3.org/2000/01/rdf-schema#label> "populacijaGodina"@sr-Latn-RS .
<http://purl.obolibrary.org/obo/IAO_0000136> <http://www.w3.org/2000/01/rdf-schema#label> "je o"@sr-Latn-RS .
<http://aims.fao.org/aos/geopolitical.owl#nationalityES> <http://www.w3.org/2000/01/rdf-schema#label> "nacionalnostES"@sr-Latn-RS .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Španska nacionalnost or Španac

@litvinovg
Copy link
Contributor

Should freemarker template filenames also have _sr_Latn_RS suffix instead of _sr_RS ?

@VeljkoMaksimovic
Copy link
Contributor Author

@litvinovg .ftl templates were working fine with sr_RS, just finished testing them, but you are right, it is better to be more specific with the script. All of those files are now renamed to end with sr_Latn_RS

@chenejac chenejac merged commit 42f8097 into vivo-project:main Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
middle PR A middle pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants