Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Remove non-language-tag-related content from i18n initialSiteConfig files #108

Merged
merged 1 commit into from
May 28, 2022

Conversation

brianjlowe
Copy link
Member

VIVO GitHub issue VIVO-3714

What does this pull request do?

  • Removes themeDir declarations from fr-CA and de-DE initialSiteConfig files. The default themeDir should be defined only once, in VIVO (not VIVO-languages) home/src/main/resources/rdf/applicationMetadata/firsttime/initialSiteConfig.rdf.
  • Removes untranslated triples.
  • Changes an en-US tag to fr-CA to align with its language folder.

How should this be tested?

Should result in no functional changes. Avoids any risk that the unnecessary themeDir properties will conflict with desired themeDir setting.

@VIVO-project/vivo-committers

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. Thanks for fixing this issue.

@chenejac chenejac merged commit 7f1d662 into vivo-project:main May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants