Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Localization of VIVO into Serbian (Latin script) #55

Merged
merged 7 commits into from
Apr 21, 2022
Merged

Localization of VIVO into Serbian (Latin script) #55

merged 7 commits into from
Apr 21, 2022

Conversation

VeljkoMaksimovic
Copy link
Contributor

This localization is dependent on changes made to Vitro in this pull request vivo-project/Vitro#250

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VeljkoMaksimovic thanks for this contribution. Can you please resolve my comments attached to files? Also, please remove your Serbian comments or translate that in English. At the end, I have one additional question. Why custom ftl files do not have script (alphabet - Latn) in its name? Can that be a problem in the case some VIVO instance has both Serbian Cyrillic and Serbian Latin Translation?

Copy link

@lidijaivanovic lidijaivanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. I have added some comments which I hope might improve translation. Also, I notice that each word first capital letter is not so common in Serbian language in titles, therefore I suggest to replace that with sentence style, i.e. capitalize only first letter of the first word.

@litvinovg
Copy link
Contributor

Should freemarker template filenames also have _sr_Latn_RS suffix instead of _sr_RS ?

@VeljkoMaksimovic
Copy link
Contributor Author

@litvinovg .ftl templates were working fine with sr_RS, just finished testing them, but you are right, it is better to be more specific with the script. All of those files are now renamed to end with sr_Latn_RS

@chenejac chenejac merged commit b4d7d75 into vivo-project:main Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
middle PR A middle pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants