-
Notifications
You must be signed in to change notification settings - Fork 27
Localization of VIVO into Serbian (Latin script) #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VeljkoMaksimovic thanks for this contribution. Can you please resolve my comments attached to files? Also, please remove your Serbian comments or translate that in English. At the end, I have one additional question. Why custom ftl files do not have script (alphabet - Latn) in its name? Can that be a problem in the case some VIVO instance has both Serbian Cyrillic and Serbian Latin Translation?
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
.../webapp/src/main/webapp/templates/freemarker/userAccounts-confirmEmailChangedEmail_sr_RS.ftl
Outdated
Show resolved
Hide resolved
...ebapp/src/main/webapp/templates/freemarker/userAccounts-passwordResetCompleteEmail_sr_RS.ftl
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/templates/freemarker/search-help_sr_RS.ftl
Outdated
Show resolved
Hide resolved
...webapp/src/main/webapp/templates/freemarker/userAccounts-passwordResetPendingEmail_sr_RS.ftl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. I have added some comments which I hope might improve translation. Also, I notice that each word first capital letter is not so common in Serbian language in titles, therefore I suggest to replace that with sentence style, i.e. capitalize only first letter of the first word.
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
sr_Latn_RS/webapp/src/main/webapp/i18n/all_sr_Latn_RS.properties
Outdated
Show resolved
Hide resolved
Should freemarker template filenames also have _sr_Latn_RS suffix instead of _sr_RS ? |
@litvinovg .ftl templates were working fine with sr_RS, just finished testing them, but you are right, it is better to be more specific with the script. All of those files are now renamed to end with sr_Latn_RS |
This localization is dependent on changes made to Vitro in this pull request vivo-project/Vitro#250