Respectful keyboard shortcuts #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallanic
changed the title
Carglass
approved these changes
Apr 28, 2018
| // registering / unregistering shortcuts when necessary | ||
| registerShortcuts(); | ||
| win.on('focus', registerShortcuts); | ||
| win.on('blur', unregisterShortcuts); |
There was a problem hiding this comment.
interesting, I would not have thought to do it this way ˆˆ'
There was a problem hiding this comment.
yeah, you would think there are more obvious ways, and more documented too 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://github.com/Carglass/viz/projects/1#card-9340457
Note
This branch was originally for the slider dev, but took care of this more urgent matter first.
Will create a different branch / PR for the slider.
Changes
How To Test
Applicable Research Resources