Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HighResolution #449

Closed
wants to merge 6 commits into from
Closed

HighResolution #449

wants to merge 6 commits into from

Conversation

schaumb
Copy link
Contributor

@schaumb schaumb commented Dec 4, 2023

No description provided.

@schaumb schaumb marked this pull request as draft December 4, 2023 16:51
@schaumb schaumb marked this pull request as ready for review December 6, 2023 17:31
@schaumb schaumb requested a review from simzer December 6, 2023 17:31
simzer
simzer requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@simzer simzer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These Low/High presets are arbitrary. They were optimized for the QT canvas. We should not hard-code these into the lib anymore. Instead, we need the PathSampler::dMax, PathSampler::hMax parameters on the API.

@schaumb schaumb marked this pull request as draft December 7, 2023 14:46
@schaumb
Merge remote-tracking branch 'origin/main' into resolution
be15ee5 
# Conflicts:
#	src/apps/weblib/cinterface.cpp
#	src/apps/weblib/cinterface.h
#	src/apps/weblib/interface.cpp
#	src/apps/weblib/interface.h
#	src/apps/weblib/ts-api/cvizzu.types.d.ts
#	src/apps/weblib/ts-api/module/cchart.ts
#	src/base/gui/widget.h
#	src/chart/main/chart.h
#	src/chart/ui/chart.cpp
#	src/chart/ui/chart.h
#	test/integration/test_cases/test_cases.json
#	test/integration/tests/config_tests.json
#	test/integration/tests/features.json
#	test/integration/tests/fixes.json
@schaumb
Copy link
Contributor Author

schaumb commented Jul 8, 2024

I created another PR.

@schaumb schaumb closed this Jul 8, 2024
@schaumb schaumb deleted the resolution branch July 15, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simzer simzer simzer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schaumb @simzer